Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant "Note:" prefixes #10920

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Remove redundant "Note:" prefixes #10920

merged 1 commit into from
Nov 8, 2018

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Nov 8, 2018

Hugo shortcodes already create prefixes as explained here.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2018
@davidxia
Copy link
Contributor Author

davidxia commented Nov 8, 2018

Currently some docs look like this.

https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#label-selector-updates

image

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit aba4e72

https://deploy-preview-10920--kubernetes-io-master-staging.netlify.com

1 similar comment
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit aba4e72

https://deploy-preview-10920--kubernetes-io-master-staging.netlify.com

@davidxia
Copy link
Contributor Author

davidxia commented Nov 8, 2018

Docs afterwards

https://deploy-preview-10920--kubernetes-io-master-staging.netlify.com/docs/concepts/workloads/controllers/deployment/#label-selector-updates

image

@tengqm
Copy link
Contributor

tengqm commented Nov 8, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6c0d730 into kubernetes:master Nov 8, 2018
@davidxia davidxia deleted the patch1 branch November 8, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

@ianychoi ianychoi Awaiting requested review from ianychoi

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidxia @k8sio-netlify-preview-bot @tengqm @k8s-ci-robot