Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 2016-07-00-Cross-Cluster-Services.md，fix 404 #11009

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Update 2016-07-00-Cross-Cluster-Services.md，fix 404 #11009

merged 1 commit into from
Nov 15, 2018

Conversation

xichengliudui
Copy link
Contributor

Update 2016-07-00-Cross-Cluster-Services.md，fix 404 not found

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2018
@xichengliudui
Copy link
Contributor Author

/assign @natekartchner

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a68fe08

https://deploy-preview-11009--kubernetes-io-master-staging.netlify.com

@Bradamant3
Copy link
Contributor

I'm grudgingly approving this PR for merge, but we need to find a better way to deal with old broken links that aren't useful anymore. This one in particular is of some concern because the 1.8 branch is out of date and undoubtedly not accepting issues or PRs anymore -- although the likelihood of anyone reading a blog post from almost two and a half years ago is also undoubtedly very unlikely.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit f866725 into kubernetes:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@Bradamant3 Bradamant3

@natekartchner natekartchner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xichengliudui @k8sio-netlify-preview-bot @Bradamant3 @k8s-ci-robot @natekartchner