Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh controller role list on rbac description page #11207

Closed

Conversation

WanLinghao
Copy link
Contributor

Now the cluster got more controller roles, refresh the list.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: steveperry-53

If they are not already assigned, you can assign the PR to them by writing /assign @steveperry-53 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Nov 23, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ad7ad92

https://deploy-preview-11207--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Nov 23, 2018

@WanLinghao Should we target this at dev-1.13 branch?

@WanLinghao
Copy link
Contributor Author

@tengqm Yeah, I think so

@WanLinghao
Copy link
Contributor Author

@tengqm But I do't know how to target this.. Could give me some hints?

@tengqm
Copy link
Contributor

tengqm commented Nov 24, 2018

@WanLinghao When raising the PR, choose the upstream branch you are targeting.

@WanLinghao
Copy link
Contributor Author

@tengqm so should I close this and start a new one?

@tengqm
Copy link
Contributor

tengqm commented Nov 24, 2018

@WanLinghao I don't have a better solution.

@Bradamant3
Copy link
Contributor

@WanLinghao you can also change the base branch in the GitHub UI, if it helps. (I can't see how to do it myself, as a maintainer. If you continue to have issues, though, I can pull down your fork and do it on the command line. I'll get through other 1.13 PRs and then check back here. lmk if I can help further.)

@Bradamant3 Bradamant3 added this to the 1.13 milestone Nov 26, 2018
@WanLinghao
Copy link
Contributor Author

@Bradamant3 Hello,plz check this one #11290

@Bradamant3
Copy link
Contributor

replaced by #11290

@Bradamant3 Bradamant3 closed this Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants