-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for secret, configmap and downwardAPI file permissions for 1.4 release #1178
Conversation
The test fail seems unrelated. It says: |
And this seems to be the fixed, so probably this will pass once this other PR is merged: #1159 |
Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions. docs/user-guide/configmap/index.md, line 417 [r1] (raw file):
In general, prefer active to passive voice. "Projecting keys to specific paths and file permissions" docs/user-guide/configmap/index.md, line 419 [r1] (raw file):
Same w/r/t active/passive voice. "You can project keys to specific paths and specific permissions on a per-file basis. The Secrets user guide explains the syntax." docs/user-guide/downward-api/index.md, line 117 [r1] (raw file):
"Projecting keys to specific paths and file permissions" docs/user-guide/downward-api/index.md, line 119 [r1] (raw file):
"You can project keys to specific paths and specific permissions on a per-file basis. The Secrets user guide explains the syntax." Comments from Reviewable |
Some minor wording changes; once cleaned up, I'll add Docs LGTM. |
Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions. docs/user-guide/configmap/index.md, line 417 [r1] (raw file):
|
Thanks, I think I addressed them all. Please take another look :) Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions. Comments from Reviewable |
@rata , would you mind rebasing this PR on the latest from release-1.4? I'm testing some staging things. |
The patch that adds this feature in core kubernetes, kubernetes/kubernetes#28936, was merged and will be released with kubernetes 1.4.
@devin-donnelly sure, np! Rebased now :) |
Thanks! And Docs LGTM. Still going to hold for Tech Review; I'll flag it. |
@devin-donnelly thanks! I wrote the core kubernetes patch (kubernetes/kubernetes#28936) adding this functionality, so maybe there is no need to bother someone else for the tech review. But I understand if someone from the kubernetes org needs to confirm. Just saying in case we can avoid @bgrant0607's time! :) |
Oh, okay. No problem, then. |
* New content dir for 2.11 docs `/content/2.11` is basically a copy of `/content/2.10`, where all new content pertaining to 2.11 should reside. I tried to remove all direct references to `2.10` and made them relative dir references instead, so this process gets easier as new major versions are released.
Signed-off-by: Henok Biadglign Ademtew <46082799+HenokB@users.noreply.github.com>
The patch that adds this feature in core kubernetes,
kubernetes/kubernetes#28936, was merged and will be
released with kubernetes 1.4.
This change is