Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for secret, configmap and downwardAPI file permissions for 1.4 release #1178

Merged
merged 1 commit into from
Sep 13, 2016

Conversation

rata
Copy link
Member

@rata rata commented Sep 7, 2016

The patch that adds this feature in core kubernetes,
kubernetes/kubernetes#28936, was merged and will be
released with kubernetes 1.4.


This change is Reviewable

@rata
Copy link
Member Author

rata commented Sep 7, 2016

The test fail seems unrelated. It says: examples_test.go:293: ../docs/user-guide/sj.yaml: sj does not have a test case defined

@rata rata changed the title Add documentation for secret, configmap and downwardAPI file permissions Add documentation for secret, configmap and downwardAPI file permissions for 1.4 release Sep 7, 2016
@rata
Copy link
Member Author

rata commented Sep 7, 2016

And this seems to be the fixed, so probably this will pass once this other PR is merged: #1159

@devin-donnelly
Copy link
Contributor

Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.


docs/user-guide/configmap/index.md, line 417 [r1] (raw file):

Projections of keys to specific paths and file permissions

In general, prefer active to passive voice.

"Projecting keys to specific paths and file permissions"


docs/user-guide/configmap/index.md, line 419 [r1] (raw file):

#### Projections of keys to specific paths and file permissions

Projections of keys to specific paths and specific permissions per file are also

Same w/r/t active/passive voice.

"You can project keys to specific paths and specific permissions on a per-file basis. The Secrets user guide explains the syntax."


docs/user-guide/downward-api/index.md, line 117 [r1] (raw file):

In future, it will be possible to specify a specific annotation or label.

#### Projections of keys to specific paths and file permissions

"Projecting keys to specific paths and file permissions"


docs/user-guide/downward-api/index.md, line 119 [r1] (raw file):

#### Projections of keys to specific paths and file permissions

Projections of keys to specific paths and specific permissions per file are also

"You can project keys to specific paths and specific permissions on a per-file basis. The Secrets user guide explains the syntax."


Comments from Reviewable

@devin-donnelly
Copy link
Contributor

Some minor wording changes; once cleaned up, I'll add Docs LGTM.

@rata
Copy link
Member Author

rata commented Sep 8, 2016

Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.


docs/user-guide/configmap/index.md, line 417 [r1] (raw file):

Previously, devin-donnelly wrote…

In general, prefer active to passive voice.

"Projecting keys to specific paths and file permissions"

Fixed! :)

The title was based on this other from the "secrets" section: "Projection of secret keys to specific paths"


docs/user-guide/configmap/index.md, line 419 [r1] (raw file):

Previously, devin-donnelly wrote…

Same w/r/t active/passive voice.

"You can project keys to specific paths and specific permissions on a per-file basis. The Secrets user guide explains the syntax."

Fixed

docs/user-guide/downward-api/index.md, line 117 [r1] (raw file):

Previously, devin-donnelly wrote…

"Projecting keys to specific paths and file permissions"

Fixed!

docs/user-guide/downward-api/index.md, line 119 [r1] (raw file):

Previously, devin-donnelly wrote…

"You can project keys to specific paths and specific permissions on a per-file basis. The Secrets user guide explains the syntax."

Fixed!

Comments from Reviewable

@rata
Copy link
Member Author

rata commented Sep 8, 2016

Thanks, I think I addressed them all. Please take another look :)


Review status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions.


Comments from Reviewable

@devin-donnelly
Copy link
Contributor

@rata , would you mind rebasing this PR on the latest from release-1.4? I'm testing some staging things.

The patch that adds this feature in core kubernetes,
kubernetes/kubernetes#28936, was merged and will be
released with kubernetes 1.4.
@rata
Copy link
Member Author

rata commented Sep 9, 2016

@devin-donnelly sure, np! Rebased now :)

@devin-donnelly
Copy link
Contributor

Thanks! And Docs LGTM. Still going to hold for Tech Review; I'll flag it.

@rata
Copy link
Member Author

rata commented Sep 9, 2016

@devin-donnelly thanks! I wrote the core kubernetes patch (kubernetes/kubernetes#28936) adding this functionality, so maybe there is no need to bother someone else for the tech review.

But I understand if someone from the kubernetes org needs to confirm. Just saying in case we can avoid @bgrant0607's time! :)

@devin-donnelly
Copy link
Contributor

Oh, okay. No problem, then.

@devin-donnelly devin-donnelly merged commit 26d8a59 into kubernetes:release-1.4 Sep 13, 2016
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Sep 22, 2022
* New content dir for 2.11 docs

`/content/2.11` is basically a copy of `/content/2.10`, where all new
content pertaining to 2.11 should reside. I tried to remove all direct
references to `2.10` and made them relative dir references instead, so
this process gets easier as new major versions are released.
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
Signed-off-by: Henok Biadglign Ademtew <46082799+HenokB@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants