-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImagePolicyWebhook docs #1188
Add ImagePolicyWebhook docs #1188
Conversation
LGTM, thanks @ecordell |
Part of kubernetes/enhancements#59 |
@ecordell Can you make this change against the release-1.4 branch instead of master? |
93a26a6
to
945b2ad
Compare
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
945b2ad
to
a39713c
Compare
CLAs look good, thanks! |
@jaredbhatti done! |
@ecordell , would you mind rebasing this on the latest in release-1.4 real quick? I'm testing out a new staging capability. |
a39713c
to
5832208
Compare
} | ||
``` | ||
|
||
To disallow acceess, the service would return: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*access
Please mention the flag required to turn this feature on (ImageReviewPolicy). Other than that I found 1 typo and like the rest. |
5832208
to
3dd5924
Compare
Nice catch @Q-Lee (I have a sticky Added info on enabling the controller to the intro in the docs. |
LGTM, @davidopp do you want to apply the lgtm label? |
Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions. docs/admin/admission-controllers.md, line 83 [r2] (raw file):
Passive voice/future tense/pronouns. "The ImagePolicyWebhook plug-in allows a backend webhook to make admission decisions. You enable this plug-in by setting the docs/admin/admission-controllers.md, line 90 [r2] (raw file):
"ImagePolicyWebhook uses the admission controller config file..." docs/admin/admission-controllers.md, line 106 [r2] (raw file):
The kubeconfig file's cluster field must point to the remote service, and the user field must contain the returned authorizer. Comments from Reviewable |
3dd5924
to
095f9d4
Compare
@devin-donnelly fixed |
Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions. Comments from Reviewable |
Good from my perspective. Adding the tech review tag to make sure this gets a tech LGTM. |
Never mind, looks like @philips took care of it. I'll merge this one in. |
* Add Buoyant training course signup to training & support page. * Remove Kubernetes course. Not sure why that would be on a Linkerd page. * target=_blank for external links Signed-off-by: William Morgan <william@buoyant.io>
This documents the ImagePolicyWebhook Admission controller as proposed in the image-provenance proposal.
cc @kubernetes/docs
This change is