Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Linux shell installation-command of minikube #12358

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

florianb
Copy link

@florianb florianb commented Jan 24, 2019

Use mv instead the combination of cp and rm to put minikube into /usr/local/bin

Use `mv` instead the combination of `cp` and `rm` to put minikube into `/usr/local/bin`
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 24, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 18a129a

https://deploy-preview-12358--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

/assign @Bradamant3

@Rajakavitha1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2019
@Rajakavitha1
Copy link
Contributor

@Bradamant3 Please take a look at this PR.

@zhangxiaoyu-zidif
Copy link
Contributor

cp may fail, if there is a file with same name already. so retaining it is better.

@zparnold
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 832a05e into kubernetes:master Feb 13, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
Use `mv` instead the combination of `cp` and `rm` to put minikube into `/usr/local/bin`
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
Use `mv` instead the combination of `cp` and `rm` to put minikube into `/usr/local/bin`
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
Use `mv` instead the combination of `cp` and `rm` to put minikube into `/usr/local/bin`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants