Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change typo in kubectl output from ClusterIP to LoadBalancer #12545

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

brendanwr
Copy link
Contributor

@brendanwr brendanwr commented Feb 7, 2019

The frontend service should show type of "LoadBalancer"

The frontend service should show type of "LoadBalancer"
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 7, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 7, 2019
@netlify
Copy link

netlify bot commented Feb 7, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 73198bc

https://deploy-preview-12545--kubernetes-io-master-staging.netlify.com

@brendanwr
Copy link
Contributor Author

/check-cla

1 similar comment
@brendanwr
Copy link
Contributor Author

/check-cla

@Rajakavitha1
Copy link
Contributor

Thanks for the PR @brendanwr !

Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

memo Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

@brendanwr
Copy link
Contributor Author

/check-cla

1 similar comment
@brendanwr
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 9, 2019
@brendanwr
Copy link
Contributor Author

/assign @jimangel

@zparnold zparnold changed the title Minor Type Change typo in kubectl output from ClusterIP to LoadBalancer Feb 13, 2019
@zparnold
Copy link
Member

/approve

@zparnold
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit bc3a036 into kubernetes:master Feb 13, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
The frontend service should show type of "LoadBalancer"
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
The frontend service should show type of "LoadBalancer"
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
The frontend service should show type of "LoadBalancer"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants