Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Recommended docker version #12591

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Updated Recommended docker version #12591

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
807ded0
Updated Recommended docker version
Feb 11, 2019
11e65cb
minor changes
Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions content/en/docs/setup/cri.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Use the following commands to install Docker on your system:
stable"

## Install docker ce.
apt-get update && apt-get install docker-ce=18.06.0~ce~3-0~ubuntu
apt-get update && apt-get install docker-ce=18.06.2~ce~3-0~ubuntu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/website/pull/12591/files#diff-9b5d940e9fc0e3fab81c81aad0dc300fR23
please change this value to 18.06.2 too.

Version 18.06.2 is recommended, ....


# Setup daemon.
cat > /etc/docker/daemon.json <<EOF
Expand Down Expand Up @@ -78,7 +78,7 @@ yum-config-manager \
https://download.docker.com/linux/centos/docker-ce.repo

## Install docker ce.
yum update && yum install docker-ce-18.06.1.ce
yum update && yum install docker-ce-18.06.2.ce

## Create /etc/docker directory.
mkdir /etc/docker
Expand Down Expand Up @@ -109,6 +109,14 @@ systemctl restart docker
Refer to the [official Docker installation guides](https://docs.docker.com/engine/installation/)
for more information.

Please Note:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the text Please Note: and wrap the whole block with {{< caution >}} .... {{< /caution >}}

example here:
https://github.com/kubernetes/website/blob/807ded0b0df21c37239e895943a8b77c6efdd0cc/content/en/docs/setup/independent/high-availability.md

also please move this block above the Docker section.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 Thanks for pointing it out.Corrected it. :)

A flaw was found in the way runc handled system file descriptors when running containers.
A malicious container could use this flaw to overwrite contents of the runc binary and
consequently run arbitrary commands on the container host system.

Please refer to this link for more information about this issue
[cve-2019-5736 : runc vulnerability ] (https://access.redhat.com/security/cve/cve-2019-5736)

## CRI-O

This section contains the necessary steps to install `CRI-O` as CRI runtime.
Expand Down