Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the borken link in kubelet-integration.md page #12864

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Fix the borken link in kubelet-integration.md page #12864

merged 1 commit into from
Feb 27, 2019

Conversation

DanyC97
Copy link
Contributor

@DanyC97 DanyC97 commented Feb 26, 2019

Fixes #12859

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2019
@netlify
Copy link

netlify bot commented Feb 26, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 990539e

https://deploy-preview-12864--kubernetes-io-master-staging.netlify.com

neolit123
neolit123 reviewed Feb 27, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @DanyC97
let's move the outside of the links`.

added a couple of comments with recommendations.

/sig cluster-lifecycle

content/en/docs/setup/independent/kubelet-integration.md Outdated
| `kubelet` | Installs the `/usr/bin/kubelet` binary. |
| `kubectl` | Installs the `/usr/bin/kubectl` binary. |
| `kubernetes-cni` | Installs the official CNI binaries into the `/opt/cni/bin` directory. |
| `cri-tools` | Installs the `/usr/bin/crictl` binary from [https://github.com/kubernetes-incubator/cri-tools](https://github.com/kubernetes-incubator/cri-tools). |
| `cri-tools` | Installs the `/usr/bin/crictl` binary from [cri-tools git repo](https://github.com/kubernetes-incubator/cri-tools). |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change:
[cri-tools git repo] -> the [cri-tools git repository]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

content/en/docs/setup/independent/kubelet-integration.md Outdated
@@ -193,10 +193,10 @@ The DEB and RPM packages shipped with the Kubernetes releases are:

| Package name | Description |
|--------------|-------------|
| `kubeadm` | Installs the `/usr/bin/kubeadm` CLI tool and [The kubelet drop-in file(#the-kubelet-drop-in-file-for-systemd) for the kubelet. |
| `kubeadm` | Installs the `/usr/bin/kubeadm` CLI tool and [the kubelet drop-in file](#the-kubelet-drop-in-file-for-systemd) for the kubelet. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[the kubelet drop-in file] -> the [kubelet drop-in file]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 27, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 27, 2019

@neolit123 pls help review again. thank you!

neolit123
neolit123 reviewed Feb 27, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 27, 2019

@zacharysarah who might be the sig-docs person who can approve the PR following the review from @neolit123 ?

@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit ab5e8c0 into kubernetes:master Feb 27, 2019
@DanyC97 DanyC97 deleted the fix-12859 branch February 28, 2019 11:02
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@DanyC97
Fix the borken link in kubelet-integration.md page (kubernetes#12864)
4e4a529
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@DanyC97
Fix the borken link in kubelet-integration.md page (kubernetes#12864)
ea6ee6d
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@DanyC97 @yagonobre
Fix the borken link in kubelet-integration.md page (kubernetes#12864)
77dc5db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@neolit123 neolit123

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanyC97 @zacharysarah @k8s-ci-robot @neolit123