-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows documentation updates for 1.14 #12929
Merged
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
264f4ed
Updated the note to indicate doc work for 1.14
craiglpeters aef823f
first attempt at md export from gdoc
craiglpeters 0e14aa5
simplifyig
craiglpeters 425a934
big attempt
craiglpeters 23508d5
moving DRAFT windows content to PR for review
craiglpeters 5ebda61
moving content to PR in markdown for review
craiglpeters a449d5e
updated note tags
craiglpeters 06c7578
Delete windows-contributing.md
michmike 7ad4efc
fixed formatting in intro and cluster setup guide
craiglpeters 5292447
updating formatting for running containers guide
craiglpeters 07352c0
rejiggered end of troubleshooting
craiglpeters e220d25
fixed minor typos
craiglpeters 67d065b
Clarified the windows binary download step
craiglpeters 2889599
Update _index.md
michmike 3dd18c3
Update _index.md
michmike f146655
Update _index.md
michmike 9b1b1b3
Update _index.md
michmike 185124a
updating relative docs links
michmike 394937e
Update _index.md
michmike a13278b
Update _index.md
michmike 945e282
formatted for correct step numbering
craiglpeters 914af4f
fix typos
craiglpeters 530f56d
Update _index.md
michmike e495861
Update _index.md
michmike f4210e6
Update _index.md
michmike cd82c1f
Update _index.md
michmike 81d5ac7
Update _index.md
michmike f18f1a8
Update _index.md
michmike b24c692
Fixed a few whitespace issues
craiglpeters 418fd43
Update _index.md
michmike 814f384
Update _index.md
michmike 8376485
Update _index.md
michmike 1591c84
Merge branch 'dev-1.14' into dev-1.14
michmike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want the page to look like the other content pages, you can add a template type attribute in the front matter:
content_template: templates/concept
. With this template, you are required to include anoverview
and then abody
. See another page under concepts for an example. This template will provide an internal toc at the top, based upon the main headers in the doc. May help navigation of the page.Or, I see that other pages in setup do not set a template type and instead include the toc shortcode at the top,
{{< toc >}}. See content/en/docs/setup/node-conformance.md as an example.
nit: the tables could be converted to Markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let us merge this PR and i will create a new one to do these changes. very helpful hints @kbhawkey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbhawkey i fixed this in another PR and will ping you there :)