Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken link in E2E Testing blog post #13371

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Fixed broken link in E2E Testing blog post #13371

merged 1 commit into from
Mar 25, 2019

Conversation

evilyeti
Copy link
Contributor

Fixed a broken link in the End2End testing blogpost.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 25, 2019
@netlify
Copy link

netlify bot commented Mar 25, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e027a74

https://deploy-preview-13371--kubernetes-io-master-staging.netlify.com

@rlenferink
Copy link
Member

/lgtm
/approve

Thanks for fixing 🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2019
@evilyeti
Copy link
Contributor Author

Sure!

/assign @bobsky

@kbarnard10
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10, rlenferink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 28dd4d5 into kubernetes:master Mar 25, 2019
@zacharysarah
Copy link
Contributor

@evilyeti @rlenferink @kbarnard10 Today is the 1.14 release day. Please don't merge PRs to master on release days. We freeze the repo to minimize potential conflicts between master and the development branch.

In this case, the freeze was not announced clearly, for which I apologize. This notice is solely to raise visibility about release day freezes.

@rlenferink
Copy link
Member

@evilyeti @rlenferink @kbarnard10 Today is the 1.14 release day. Please don't merge PRs to master on release days. We freeze the repo to minimize potential conflicts between master and the development branch.

In this case, the freeze was not announced clearly, for which I apologize. This notice is solely to raise visibility about release day freezes.

Apologies, I somehow completely missed that. I'll be paying attention to that next time 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@bobsky bobsky

@rlenferink rlenferink

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evilyeti @rlenferink @kbarnard10 @k8s-ci-robot @zacharysarah @bobsky