Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API reference for 1.14 #13442

Merged
merged 1 commit into from
Mar 27, 2019
Merged

API reference for 1.14 #13442

merged 1 commit into from
Mar 27, 2019

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 26, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 26, 2019
@netlify
Copy link

netlify bot commented Mar 26, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 303edbe

https://deploy-preview-13442--kubernetes-io-master-staging.netlify.com

@jimangel
Copy link
Member

jimangel commented Mar 26, 2019 •
edited
Loading

/hold

Thanks @tengqm for the fast work! I would like to test the instructions and validate from an outside perspective before merging this so you don't need to do this again in 3 months :)

ref: #13396

Preview: https://deploy-preview-13442--kubernetes-io-master-staging.netlify.com/docs/reference/generated/kubernetes-api/v1.14

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2019
@jimangel jimangel mentioned this pull request Mar 27, 2019
Closed
@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2019
@tengqm
Copy link
Contributor Author

tengqm commented Mar 27, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2019
@tengqm tengqm merged commit 7c47295 into kubernetes:master Mar 27, 2019
@tengqm tengqm deleted the apiref-1.14 branch March 27, 2019 02:57
@tengqm tengqm mentioned this pull request Mar 27, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@jimangel jimangel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @jimangel @k8s-ci-robot