Localised update-imported-docs/README.md to Hindi #13936
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit a5b6bd6 https://deploy-preview-13936--kubernetes-io-master-staging.netlify.com |
|
I signed it |
|
/check-cla |
|
I signed it |
k8s-ci-robot
added
cncf-cla: yes
|
/language hi |
k8s-ci-robot
added
size/L
This reverts commit 94fd109.
k8s-ci-robot
added
size/M
There was a problem hiding this comment.
@avidLearnerInProgress Thanks for the PR ✨
Thanks fo spending time for converting docs to Hindi but please don't translate directly from google. Google some times messed up with language structure. I had requested some changes, please update PR with requested changes
update-imported-docs/README-hi.md
Outdated
|
|
||
| # आयातित डॉक्स अपडेट करें | ||
|
|
||
| यह स्क्रिप्ट डॉक्स फ़ाइलों को अपडेट करती है जो अन्य रिपॉजिट से उत्पन्न होती हैं। |
There was a problem hiding this comment.
रिपॉजिट should be replace with रेपोस or english for that is repos
There was a problem hiding this comment.
Other reviewers reviews needed
There was a problem hiding this comment.
lets go with the english repos!!!
There was a problem hiding this comment.
I am sorry, I just checked on the preferred word usage that @mittalyashu has put together it reads: रीपॉज़टॉरी
There was a problem hiding this comment.
ohh! but here रिपॉजिट doesn't feel good if we read the sentence. but it's correct translation for the word repository
There was a problem hiding this comment.
रेपोस or repos or रीपॉज़टॉरी or रीपॉज़टॉरी!!
|
/cc @Rajakavitha1 |
|
Any updates on this PR? |
Will update this PR this weekend |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @jaredbhatti |
|
/cc @mittalyashu |
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
Why there is a new line at the top of the file?
| @@ -66,3 +67,12 @@ given command or a short script to generate the docs from within a repo. | |||
| To fix relative links within your imported files, set the repo config's | |||
| `gen-absolute-links` property to `true`. You can find an example of this in | |||
| [`release.yml`](release.yml). | |||
|
|
|||
|
|
|||
| ## Footnotes: | |||
There was a problem hiding this comment.
I don't think we need to add about Hindi localization in the main update-imported-docs/README.md file.
There was a problem hiding this comment.
Yes, Please dont add about Hindi localization in the main update-imported-docs/README.md file!!!
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
lifecycle/rotten
|
@avidLearnerInProgress: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR has been open for almost 9 months and needs a rebase. I have no problem re-opening this once everything is resolved. /close It looks like a minor change, but will also wait for a Hindi-native speaker to |
|
@jimangel: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes:
README.mdwithin folderupdate-imported-docs, added footnotes that link the Hindi localized version of the readme. Also added my GitHub account details showcasing the person responsible for this translationReview:
README.mdfileREADME-hi.mdCloses #13919