-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kubectl ref contrib guide #15199
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit a648dc1 https://deploy-preview-15199--kubernetes-io-master-staging.netlify.com |
0a19328
to
a648dc1
Compare
/assign @tengqm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Get a clone of the kubernetes/kubernetes repository as k8s.io/kubernetes: | ||
|
||
```shell | ||
git clone https://github.com/kubernetes/kubernetes $GOPATH/src/k8s.io/kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k/kubernetes is now switched to go modules. Is it still required to clone into $GOPATH?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @ialidzhikov . Right, what do you suggest? There are various ways to setup the build for the kubectl reference. I would suggest the most straightforward and repeatable process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting in Go 1.13 (1 August, 2019), module mode will be the default for all development. The major feature of go modules is that they allow you to decouple from the GOPATH and develop outside of it.
If possible, I would not git clone in GOPATH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I reread https://github.com/golang/go/wiki/Modules and now have some idea about go.mod, GOPATH, GO111MODULE.
See issue #14111 .