Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kubectl ref contrib guide #15199

Merged
merged 2 commits into from
Jul 6, 2019
Merged

update kubectl ref contrib guide #15199

merged 2 commits into from
Jul 6, 2019

Conversation

kbhawkey
Copy link
Contributor

@kbhawkey kbhawkey commented Jun 29, 2019 •
edited
Loading

See issue #14111 .

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 29, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 29, 2019
@netlify
Copy link

netlify bot commented Jun 29, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a648dc1

https://deploy-preview-15199--kubernetes-io-master-staging.netlify.com

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jul 1, 2019

Preview:
https://deploy-preview-15199--kubernetes-io-master-staging.netlify.com/docs/contribute/generate-ref-docs/kubectl/

@kbhawkey kbhawkey changed the title [WIP] update kubectl ref contrib guide update kubectl ref contrib guide Jul 1, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2019
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jul 1, 2019

/assign @tengqm
/assign @makoscafee

@tengqm
Copy link
Contributor

tengqm commented Jul 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0c4353e into kubernetes:master Jul 6, 2019
ialidzhikov
ialidzhikov reviewed Jul 14, 2019
View reviewed changes
content/en/docs/contribute/generate-ref-docs/kubectl.md
Get a clone of the kubernetes/kubernetes repository as k8s.io/kubernetes:

```shell
git clone https://github.com/kubernetes/kubernetes $GOPATH/src/k8s.io/kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k/kubernetes is now switched to go modules. Is it still required to clone into $GOPATH?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @ialidzhikov . Right, what do you suggest? There are various ways to setup the build for the kubectl reference. I would suggest the most straightforward and repeatable process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting in Go 1.13 (1 August, 2019), module mode will be the default for all development. The major feature of go modules is that they allow you to decouple from the GOPATH and develop outside of it.
If possible, I would not git clone in GOPATH.

Copy link
Contributor Author

@kbhawkey kbhawkey Jul 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I reread https://github.com/golang/go/wiki/Modules and now have some idea about go.mod, GOPATH, GO111MODULE.

@kbhawkey kbhawkey deleted the kubectl-gen-contrib branch October 9, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@tengqm tengqm

@makoscafee makoscafee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kbhawkey @tengqm @k8s-ci-robot @ialidzhikov @makoscafee