Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admission v1 docs #15985

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Admission v1 docs #15985

merged 1 commit into from
Sep 6, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 21, 2019 •
edited
Loading

Preview at:
https://deploy-preview-15985--kubernetes-io-vnext-staging.netlify.com/docs/reference/access-authn-authz/extensible-admission-controllers/

Docs for:

  • Admission webhook enhancements#492
  • Admission: promote to v1
  • Admission: make failurePolicy: Fail default in v1
  • Admission: make matchPolicy: Equivalent default in v1
  • Admission: make sideEffects field required in v1
  • Admission: require webhook names to be unique in v1
  • AdmissionReview: promote types to v1
  • AdmissionReview: allow dispatcher to speak v1
  • AdmissionReview: in v1, fix bug with response.uid, kind, apiVersion not being validated in admission responses
  • Admission v1: limit webhooks to no side effects

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 21, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 21, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 23dec12

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d726f3ae2394700081e2f01

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 21, 2019
@liggitt liggitt mentioned this pull request Aug 21, 2019
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2019
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 21, 2019
@liggitt liggitt force-pushed the admission-v1 branch 3 times, most recently from fae6965 to b098ad3 Compare August 21, 2019 14:27
@liggitt liggitt changed the title WIP - Admission v1 docs Admission v1 docs Aug 21, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2019
@liggitt
Copy link
Member Author

liggitt commented Aug 21, 2019

/cc @jpbetz @sttts @roycaihw

sftim
sftim reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback

content/en/docs/reference/access-authn-authz/extensible-admission-controllers.md Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/extensible-admission-controllers.md Show resolved Hide resolved
@liggitt liggitt force-pushed the admission-v1 branch 4 times, most recently from a593dff to fb9813f Compare August 21, 2019 16:50
jpbetz
jpbetz reviewed Aug 23, 2019
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things, then lgtm

content/en/docs/reference/access-authn-authz/extensible-admission-controllers.md Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/extensible-admission-controllers.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/extensible-admission-controllers.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/extensible-admission-controllers.md Show resolved Hide resolved
@simplytunde
Copy link
Contributor

@liggitt I am the 1.16 Docs Lead. We need this PR ready for review before Sep 3.

@liggitt
Copy link
Member Author

liggitt commented Aug 27, 2019

It is ready for review now

@simplytunde
Copy link
Contributor

/milestone 1.16

@k8s-ci-robot k8s-ci-robot added this to the 1.16 milestone Aug 28, 2019
sftim
sftim approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I spotted a couple of really minor things.

content/en/docs/reference/access-authn-authz/extensible-admission-controllers.md Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/extensible-admission-controllers.md Outdated Show resolved Hide resolved
@liggitt
Copy link
Member Author

liggitt commented Sep 3, 2019

updated, thanks

@liggitt
Copy link
Member Author

liggitt commented Sep 6, 2019

rebased, technical lgtm at #15985 (review)

@simplytunde
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019
@simplytunde
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simplytunde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit b342fbc into kubernetes:dev-1.16 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@sftim sftim sftim approved these changes

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@deads2k deads2k Awaiting requested review from deads2k

@roycaihw roycaihw Awaiting requested review from roycaihw

@sttts sttts Awaiting requested review from sttts

Assignees

@simplytunde simplytunde

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @k8sio-netlify-preview-bot @simplytunde @k8s-ci-robot @jpbetz @sftim