update doc for kubelet option --reserved-cpus #17622

jianzzha · 2019-11-17T13:11:34Z

This website update is for the new kubelet CLI option: kubernetes/kubernetes#83592

k8s-ci-robot · 2019-11-17T13:11:41Z

Welcome @jianzzha!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

jianzzha · 2019-11-17T13:12:04Z

/milestone 1.17

k8s-ci-robot · 2019-11-17T13:12:05Z

@jianzzha: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-11-17T13:12:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign makoscafee
You can assign the PR to them by writing /assign @makoscafee in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2019-11-17T13:19:34Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ff05a40

https://deploy-preview-17622--kubernetes-io-master-staging.netlify.com

kbhawkey · 2019-11-17T20:34:50Z

content/en/docs/reference/command-line-tools-reference/kubelet.md

@@ -1024,6 +1024,13 @@ kubelet [flags]
      <td></td><td style="line-height: 130%; word-wrap: break-word;">If > 0, limit registry pull QPS to this value.  If 0, unlimited. (default 5) (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.)</td>
    </tr>

+     <tr>
+        <td colspan="2">--reserved-cpus string</td>
+     </tr>


Hello @jianzzha . You should make this change in the kubelet cmd line code (k8s/k8s).

@kbhawkey thanks, this file is reverted.

tengqm · 2019-11-18T01:26:57Z

content/en/docs/tasks/administer-cluster/cpu-management-policies.md

-`--system-reserved` options. CPUs reserved by these options are taken, in
+`--system-reserved` options. From 1.17, the CPU reservation list can be specified 
+explictly by kubelet --resevered-cpus option. The explicit CPU list specified by 
+--resevered-cpus will take precedence over the CPU reservation specified by 


two typos: resevered -> reserved

tengqm · 2019-11-18T01:30:22Z

content/en/docs/tasks/administer-cluster/reserve-compute-resources.md

+defined by `--kube-reserved` and `--system-reserved` options.
+
+This option is specifically designed for Telco/NFV use cases where uncontrolled 
+interrupts/timers may impact the work load performance. Users may use this option 


work load -> workload

sftim

Here are some comments & suggestions based on the website style guide

sftim · 2019-11-18T14:40:07Z

content/en/docs/tasks/administer-cluster/cpu-management-policies.md

-`--system-reserved` options. CPUs reserved by these options are taken, in
+`--system-reserved` options. From 1.17, the CPU reservation list can be specified 
+explictly by kubelet --reserved-cpus option. The explicit CPU list specified by 
+--reserved-cpus will take precedence over the CPU reservation specified by 


nit

Suggested change

--reserved-cpus will take precedence over the CPU reservation specified by

--reserved-cpus takes precedence over the CPU reservation specified by

sftim · 2019-11-18T14:41:11Z

content/en/docs/tasks/administer-cluster/reserve-compute-resources.md

+
+
+`reserved-cpus` is meant to define an explict CPU set for OS system daemons and 
+kubernetes system daemons. This option is added in 1.17 release. `reserved-cpus` 


To declare a version where this is supported, could you use a feature-state shortcode instead (eg on line 150)?

added. check if it is what's expected

sftim · 2019-11-18T14:41:41Z

content/en/docs/tasks/administer-cluster/reserve-compute-resources.md

+defined by `--kube-reserved` and `--system-reserved` options.
+
+This option is specifically designed for Telco/NFV use cases where uncontrolled 
+interrupts/timers may impact the workload performance. Users may use this option 


nit

Suggested change

interrupts/timers may impact the workload performance. Users may use this option

interrupts/timers may impact the workload performance. You can use this option

sftim · 2019-11-18T14:42:22Z

content/en/docs/tasks/administer-cluster/reserve-compute-resources.md

+workloads, with less impact from uncontrolled interrupts/timers. To move the
+system daemon, kubernetes daemons and interrupts/timers to the explict cpuset 
+defined by this option, other mechanism outside Kubernetes should be used. 
+For example in Centos, tuned toolset can be used to achieve this.


nit

Suggested change

For example in Centos, tuned toolset can be used to achieve this.

For example: in CentOS, you can do this using the tuned toolset.

sftim · 2019-11-18T14:43:20Z

content/en/docs/tasks/administer-cluster/reserve-compute-resources.md

@@ -259,4 +281,8 @@ for `kube-reserved` and `system-reserved`.
 As of Kubernetes version 1.8, the `storage` key name was changed to `ephemeral-storage`
 for the alpha release.

+As of Kubernetes version 1.17, it has been possible to **optionally** specify 


Suggested change

As of Kubernetes version 1.17, it has been possible to **optionally** specify

As of Kubernetes version 1.17, you can optionally specify

sftim · 2019-11-18T16:39:07Z

Did you want this PR to target branch dev-1.17 instead BTW?

jianzzha · 2019-11-18T18:11:10Z

Did you want this PR to target branch dev-1.17 instead BTW?
yes. I couldn't add that tag myself

tengqm · 2019-11-19T01:05:44Z

As pointed out by @sftim, this PR is about a feature to be landed in 1.17, right?
Please rebase onto dev-1.17 branch if so.
/hold

jianzzha · 2019-11-19T01:31:00Z

As pointed out by @sftim, this PR is about a feature to be landed in 1.17, right?
Please rebase onto dev-1.17 branch if so.
/hold

@tengqm yes. how to do the rebase on 1.17? any instructions?

tengqm · 2019-11-19T02:50:39Z

@jianzzha You may want to check this: https://git-scm.com/book/en/v2/Git-Branching-Rebasing

Basically, the commands are:

$ git checkout <your-pr-branch>
$ git rebase dev-1.17
First, rewinding head to replay your work on top of it...
Applying: added staged command
$ git commit --amend --no-edit
$ git push -f

jianzzha · 2019-11-19T03:20:07Z

@tengqm @sftim please review #17648 in stead - that PR is base on dev-1.17. I will close this PR. thanks!

jianzzha · 2019-11-19T03:22:39Z

@tengqm @sftim please review #17648; it captured all the changes from this PR and it is based off dev-1.17.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2019

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2019

k8s-ci-robot requested review from ConnorDoyle and derekwaynecarr November 17, 2019 13:12

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 17, 2019

kbhawkey reviewed Nov 17, 2019

View reviewed changes

tengqm reviewed Nov 18, 2019

View reviewed changes

sftim reviewed Nov 18, 2019

View reviewed changes

update doc for kubelet option --reserved-cpus

ff05a40

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2019

jianzzha closed this Nov 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update doc for kubelet option --reserved-cpus #17622

update doc for kubelet option --reserved-cpus #17622

jianzzha commented Nov 17, 2019

k8s-ci-robot commented Nov 17, 2019

jianzzha commented Nov 17, 2019

k8s-ci-robot commented Nov 17, 2019

k8s-ci-robot commented Nov 17, 2019

netlify bot commented Nov 17, 2019 •

edited

Loading

kbhawkey Nov 17, 2019

jianzzha Nov 17, 2019

tengqm Nov 18, 2019

tengqm Nov 18, 2019

sftim left a comment

sftim Nov 18, 2019

sftim Nov 18, 2019

jianzzha Nov 18, 2019

sftim Nov 18, 2019

sftim Nov 18, 2019

sftim Nov 18, 2019

sftim commented Nov 18, 2019

jianzzha commented Nov 18, 2019

tengqm commented Nov 19, 2019

jianzzha commented Nov 19, 2019

tengqm commented Nov 19, 2019

jianzzha commented Nov 19, 2019

jianzzha commented Nov 19, 2019

	--reserved-cpus will take precedence over the CPU reservation specified by
	--reserved-cpus takes precedence over the CPU reservation specified by



		`reserved-cpus` is meant to define an explict CPU set for OS system daemons and
		kubernetes system daemons. This option is added in 1.17 release. `reserved-cpus`

	interrupts/timers may impact the workload performance. Users may use this option
	interrupts/timers may impact the workload performance. You can use this option

	For example in Centos, tuned toolset can be used to achieve this.
	For example: in CentOS, you can do this using the tuned toolset.

	As of Kubernetes version 1.17, it has been possible to optionally specify
	As of Kubernetes version 1.17, you can optionally specify

update doc for kubelet option --reserved-cpus #17622

update doc for kubelet option --reserved-cpus #17622

Conversation

jianzzha commented Nov 17, 2019

k8s-ci-robot commented Nov 17, 2019

jianzzha commented Nov 17, 2019

k8s-ci-robot commented Nov 17, 2019

k8s-ci-robot commented Nov 17, 2019

netlify bot commented Nov 17, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim commented Nov 18, 2019

jianzzha commented Nov 18, 2019

tengqm commented Nov 19, 2019

jianzzha commented Nov 19, 2019

tengqm commented Nov 19, 2019

jianzzha commented Nov 19, 2019

jianzzha commented Nov 19, 2019

netlify bot commented Nov 17, 2019 •

edited

Loading