Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add kubectl events command #19387

Closed
wants to merge 1 commit into from
Closed

WIP: Add kubectl events command #19387

wants to merge 1 commit into from

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 28, 2020

This PR documents the alpha feature kubernetes/enhancements#1440, kubectl events.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kbarnard10
You can assign the PR to them by writing /assign @kbarnard10 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Feb 28, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9b8e2bf

https://deploy-preview-19387--kubernetes-io-master-staging.netlify.com

@kbhawkey
Copy link
Contributor

Hello @soltysh , If this change is for the 1.18 release, you should use the dev-1.18 branch.

@sftim
Copy link
Contributor

sftim commented Feb 29, 2020

/hold

because this PR seems to target the wrong branch

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2020
sftim
sftim reviewed Feb 29, 2020
View reviewed changes
content/en/docs/reference/kubectl/overview.md
@@ -81,6 +81,7 @@ Operation | Syntax | Description
`describe` | `kubectl describe (-f FILENAME | TYPE [NAME_PREFIX | /NAME | -l label]) [flags]` | Display the detailed state of one or more resources.
`diff` | `kubectl diff -f FILENAME [flags]`| Diff file or stdin against live configuration (**BETA**)
`edit` | `kubectl edit (-f FILENAME | TYPE NAME | TYPE/NAME) [flags]` | Edit and update the definition of one or more resources on the server by using the default editor.
`events` | `kubectl events | List events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`events` | `kubectl events | List events.
`events` | `kubectl events | List events (**ALPHA**).

?

Do users have to do anything to make alpha subcommands work?

@k8s-ci-robot
Copy link
Contributor

@soltysh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2020
@jimangel
Copy link
Member

jimangel commented Mar 16, 2020 •
edited
Loading

@soltysh please target this PR to dev-1.18 - thanks!

/cc @VineethReddy02

@sftim
Copy link
Contributor

sftim commented Mar 31, 2020

@soltysh we (SIG Docs) haven't heard from you in a while.

If you want to propose a similar change for a future release, please go ahead.

/close

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

@soltysh we (SIG Docs) haven't heard from you in a while.

If you want to propose a similar change for a future release, please go ahead.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the kubectl_events branch May 14, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@hw-qiaolei hw-qiaolei Awaiting requested review from hw-qiaolei

@zparnold zparnold Awaiting requested review from zparnold

@VineethReddy02 VineethReddy02 Awaiting requested review from VineethReddy02

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@soltysh @k8s-ci-robot @kbhawkey @sftim @jimangel