Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translations for EndpointSlices for Bahasa Indonesia #20166

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add translations for EndpointSlices for Bahasa Indonesia #20166

merged 1 commit into from
Apr 14, 2020

Conversation

evanap
Copy link

@evanap evanap commented Apr 8, 2020

Hi!

I've added the Bahasa Indonesia translation for EndpointSlices.

This PR addresses #20111.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2020
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 8, 2020
@netlify
Copy link

netlify bot commented Apr 8, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 22d5dd5

https://deploy-preview-20166--kubernetes-io-master-staging.netlify.com

@wahyuoi
Copy link
Contributor

wahyuoi commented Apr 8, 2020

/cc
/cc @phanama

wahyuoi
wahyuoi suggested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@wahyuoi wahyuoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @evanap, thank you for this translation 🎉
I've few feedback and it also need your comments.

content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Apr 9, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanap bear in mind that Kubernetes has a resource named Endpoints, not Endpoint.

content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
@evanap
Copy link
Author

evanap commented Apr 10, 2020 •
edited
Loading

Thank you for the feedback @wahyuoi @sftim. Let me know if there's more!

@wahyuoi
Copy link
Contributor

wahyuoi commented Apr 10, 2020

nice, 🎉
please squash your commits into 1 @evanap, then it's good to merge

@irvifa
Copy link
Member

irvifa commented Apr 10, 2020

You can assign me to merge this once it’s lgtm on your side. Thanks @evanap 🎉 And thank you for your thorough review @wahyuoi

@phanama
Copy link
Contributor

phanama commented Apr 10, 2020

I'm putting some reviews in a moment @irvifa @wahyuoi

phanama
phanama suggested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@phanama phanama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's for the translation @evanap !!
Here are some small reviews and discussion from me 😃

content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
@girikuncoro girikuncoro mentioned this pull request Apr 10, 2020
Closed
41 tasks
@wahyuoi wahyuoi mentioned this pull request Apr 12, 2020
Merged
@evanap evanap requested a review from wahyuoi April 13, 2020 12:36
@evanap
Copy link
Author

evanap commented Apr 13, 2020

Folks, I've updated the page with your reviews and suggestions. Thank you for the reviews and suggestions! Let me know if it still need more improvements. @wahyuoi @sftim @phanama @irvifa

@evanap evanap requested review from phanama and sftim April 13, 2020 12:36
@wahyuoi
Copy link
Contributor

wahyuoi commented Apr 13, 2020

@evanap don't forget to squash the commits into one commit

@sftim
Copy link
Contributor

sftim commented Apr 13, 2020

Other than echoing the comment about squashing, I've no feedback to add here. I don't speak bahasa Indonesia myself.

@evanap
Copy link
Author

evanap commented Apr 14, 2020

Alright, folks. Commits squashed. Thank you! @wahyuoi @sftim @irvifa @phanama

phanama
phanama suggested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@phanama phanama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some other nits! Other than those, looks great!

content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
content/id/docs/concepts/services-networking/endpoint-slices.md Outdated Show resolved Hide resolved
Translate endpoind-slices to Bahasa Indonesia
22d5dd5 
Translate hyperlinks

Fix nits:
+ leftover translation

Nits:
+ unitalicize k8s resource
+ replace trafik

Nits:
+ remove reviewers
+ correct Endpoint to Endpoints
+ remove {#endpointslice-resource}
+ translate the word flag

Nits:
+ uncapitalize selector

Update on suggestions:
+ daripada -> terhadap
+ performa -> kinerja
+ translate subdomain name
+ translate default
+ rephrasing

Updates on reviews and suggestions:
+ translate scalable
+ replace serangkaian to sekumpulan
+ use diasosiasikan instead of terasosiasi
+ use diikutinya to translate track
+ replace mengkonfigurasi with mengatur
+ treat EndpointSlices as singular

Fix leftover word

Nits:
+ unitalicize platform
+ use selektor instead of selector

Nits:
+ translate rolling update
+ use cukup instead of sangat
+ translate repacking
@phanama phanama mentioned this pull request Apr 14, 2020
Merged
@phanama
Copy link
Contributor

phanama commented Apr 14, 2020 •
edited
Loading

Looks good! Requesting approve labels @girikuncoro @irvifa
/assign @girikuncoro
/assign @irvifa

@phanama
Copy link
Contributor

phanama commented Apr 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020
@girikuncoro
Copy link
Contributor

Beautiful translation, thank you so much for your contribution @evanap! 🎉 this EndpointSlice is new feature in Kubernetes, translating/reading this page is a great learning. Feel free to translate other pages when you get time :)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit e30ddbe into kubernetes:master Apr 14, 2020
@evanap
Copy link
Author

evanap commented Apr 15, 2020

Thanks everyone! I've encountered the EndpointSlice resource before but never get to understand it until now. This work is sure is helpful in understanding it.

I'll be taking another page to translate. Again, thank you for the collaboration!

@evanap evanap mentioned this pull request Aug 7, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanama phanama phanama requested changes

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

@irvifa irvifa Awaiting requested review from irvifa

@wahyuoi wahyuoi Awaiting requested review from wahyuoi

@sftim sftim Awaiting requested review from sftim

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

@phanama phanama

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@evanap @wahyuoi @irvifa @phanama @sftim @girikuncoro @k8s-ci-robot