Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID /docs/tasks/job/automated-tasks-with-cron-jobs/ #20472

Merged
merged 1 commit into from
May 12, 2020
Merged

ID /docs/tasks/job/automated-tasks-with-cron-jobs/ #20472

merged 1 commit into from
May 12, 2020

Conversation

mufti1
Copy link
Contributor

@mufti1 mufti1 commented Apr 21, 2020

/language id

@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 21, 2020
@irvifa
Copy link
Member

irvifa commented Apr 21, 2020

/assign

sftim
sftim reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some feedback @mufti1

I don't speak bahasa Indonesia so if I have got something wrong, please skip it!

content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
@girikuncoro girikuncoro mentioned this pull request May 7, 2020
Closed
41 tasks
@girikuncoro
Copy link
Contributor

@mufti1 sorry for the delay review, seems the CI has failed, can you fix it first? you might need to include required files

6:32:48 PM: Error: Error building site: "/opt/build/repo/content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md:29:1": failed to render shortcode "capture": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/codenew.html:14:16": execute of template failed: template: shortcodes/codenew.html:14:16: executing "shortcodes/codenew.html" at <readFile $filename>: error calling readFile: file "content/id/examples/application/job/cronjob.yaml" does not exist

girikuncoro
girikuncoro requested changes May 7, 2020
View reviewed changes
Copy link
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had few nits and comments, please address them before we merge this. Also, good job on picking the word "bidang", this is a new use for our localization.

content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated

## Menulis Speifikasi Sebuah Cron

Seperti semua konfigurasi Kubernetes, sebuah CronJob membutuhkan bidang `apiVersion`, `kind`, dan `metadata`. Untuk informasi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used to keep field word, but this is a nice translation "bidang", what all other think?
cc @kubernetes/sig-docs-id-reviews

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any update regarding this mas?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second the idea of keping binding for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'll change to use field word

content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented May 11, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d33071d

https://deploy-preview-20472--kubernetes-io-master-staging.netlify.app

irvifa
irvifa suggested changes May 11, 2020
View reviewed changes
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated Show resolved Hide resolved
content/id/docs/tasks/job/automated-tasks-with-cron-jobs.md Outdated

## Menulis Speifikasi Sebuah Cron

Seperti semua konfigurasi Kubernetes, sebuah CronJob membutuhkan bidang `apiVersion`, `kind`, dan `metadata`. Untuk informasi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second the idea of keping binding for now.

@irvifa
Copy link
Member

irvifa commented May 11, 2020

/uncc @sftim

@girikuncoro
Copy link
Contributor

@mufti1 all looking good! can you squash your commits?

@mufti1
Copy link
Contributor Author

mufti1 commented May 12, 2020

@mufti1 all looking good! can you squash your commits?

okay

@mufti1 mufti1 force-pushed the id-cronjob-task branch from cb55319 to d33071d Compare May 12, 2020 03:42
@irvifa
Copy link
Member

irvifa commented May 12, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@irvifa
Copy link
Member

irvifa commented May 12, 2020

Thanks @mufti1 🎉 all looking good

@k8s-ci-robot k8s-ci-robot merged commit 7a4d1c5 into kubernetes:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@irvifa irvifa irvifa requested changes

@girikuncoro girikuncoro girikuncoro requested changes

Assignees

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mufti1 @irvifa @girikuncoro @k8s-ci-robot @sftim