Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update centos_manual_config.md #2133

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Conversation

eriknelson
Copy link
Contributor

@eriknelson eriknelson commented Jan 4, 2017

The current extras/flannel (flannel-0.5.5-1.el7) package changed the keys used for etcd configuration, see:

https://git.centos.org/blobdiff/rpms!flannel/7e924c9cf84caaf230f6a50c2a5ad5b0b6d93a9a/SOURCES!flanneld.service


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2017
Update flanneld config to reflect new configuration variables.
@eriknelson
Copy link
Contributor Author

Related issue #2086

@chenopis
Copy link
Contributor

chenopis commented Jan 9, 2017

@eriknelson perhaps you could add in the comment that the key changed for that version of flannel just in case someone is using an outdated package.

@lavalamp lavalamp removed their assignment Jan 9, 2017
@lavalamp
Copy link
Member

lavalamp commented Jan 9, 2017

@foxish @apelisse I removed myself from OWNERS in this repository, why does it keep assigning things to me?

@lavalamp lavalamp removed their assignment Jan 9, 2017
@foxish
Copy link
Contributor

foxish commented Jan 9, 2017

I can see that you're in the OWNERS file here: https://github.com/kubernetes/kubernetes.github.io/blob/master/docs/getting-started-guides/centos/centos_manual_config.md in the top metadata of that markdown file. I think we definitely need the bot to respect people who remove their assignment explicitly. I recently saw the same behavior elsewhere as well.

/cc @grodrigues3

@lavalamp
Copy link
Member

lavalamp commented Jan 9, 2017 via email

@thockin thockin merged commit 7eff877 into kubernetes:master Jan 10, 2017
@eriknelson eriknelson deleted the patch-1 branch January 10, 2017 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants