-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop vendor registry details from container image concept #21438
Drop vendor registry details from container image concept #21438
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 225517a https://deploy-preview-21438--kubernetes-io-master-staging.netlify.app |
@sftim to be clear: when you say "The amended page still needs work;" – do you want review on grammar/language here or just for me to catch the typos and let you go on your merry way? :) |
So long as these changes have no regressions, let's merge. |
@@ -9,18 +9,51 @@ weight: 10 | |||
|
|||
{{% capture overview %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to replace all capture
statements too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alas! Merge conflict, likely from #21359!
19a9b6b
to
0723bce
Compare
Re-triggered the build it had a strange memory error. |
Failed again.... the logs:
|
0723bce
to
869635d
Compare
Minimal rewrite to avoid referencing specific 3rd party vendors and their implementations.
869635d
to
225517a
Compare
(re)approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sftim What was the rationale for this change and where are the replacement docs that explain that K8s will automatically authenticate against AWS ECR periodically if running on EC2 with the appropriate IAM role permissions? I just wasted a day trying to understand how K8s was authenticating in AWS when trying to replicate our cluster in OCI, and without this documentation there is NOTHING on the Internet that explains that K8s does this automatically. |
This change helped with two issues: #20232 and #21641. The blog article https://kubernetes.io/blog/2020/05/third-party-dual-sourced-content/ provides more content about why Kubernetes avoids documenting external / third party software. |
Actually, it does, because we're using a non managed Kubernetes on AWS EC2 with IAM roles granting ECR access and it just works. The K8s documentation used to state this is how it works (based on the French page). We're running on version 1.17. Are you saying this functionality is removed in later versions? |
The Kubernetes documentation no longer includes documentation for third-party systems and software, other than those components necessary for Kubernetes to run. It's possible that the kubelet does include an integration with AWS IAM and AWS ECR; if so, that's news to me. We'd be happy to document that functionality (perhaps in a different way) if it does exist as part of Kubernetes itself because that would then be built in to Kubernetes. |
Minimal rewrite to avoid referencing specific 3rd party vendors and their implementations.
Helps with #20232 and #21641
The amended page still needs work; that's OK, that's something we can pick up in a separate pull request.