Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate existing master-node-communication to control-plane-node-communication #22300

Merged
merged 1 commit into from
Jul 5, 2020
Merged

chore: Migrate existing master-node-communication to control-plane-node-communication #22300

merged 1 commit into from
Jul 5, 2020

Conversation

irvifa
Copy link
Member

@irvifa irvifa commented Jul 3, 2020 •
edited
Loading

Related to #22296
/cc @kubernetes/sig-docs-id-reviews

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 3, 2020
@irvifa
Copy link
Member Author

irvifa commented Jul 3, 2020

/cc @wahyuoi

@k8s-ci-robot k8s-ci-robot requested a review from wahyuoi July 3, 2020 14:18
@irvifa
Copy link
Member Author

irvifa commented Jul 3, 2020

/assign

@netlify
Copy link

netlify bot commented Jul 3, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ece4828

https://deploy-preview-22300--kubernetes-io-master-staging.netlify.app

wahyuoi
wahyuoi suggested changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@wahyuoi wahyuoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irvifa,

I think there are 2 kinds of changes in this PR

  1. Changing the title (rename file)
  2. Additional paragraph

Based on /en page, there are a lot of new paragraphs and need to translate to /id too

So, I think we need to translate the whole page to make the content align with the new title

@wahyuoi
Copy link
Contributor

wahyuoi commented Jul 3, 2020

Also please don't resolve/fix/close the issue, we still need the issue as Milestone-4 tracker 😂

@irvifa
Copy link
Member Author

irvifa commented Jul 3, 2020

😂 so sorry :"")))) okay, I'll fix it in new commits.

@irvifa irvifa force-pushed the id/control-plane-node-communication branch from 525069e to 79d9834 Compare July 4, 2020 02:56
@girikuncoro girikuncoro mentioned this pull request Jul 4, 2020
Closed
51 tasks
girikuncoro
girikuncoro requested changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 I have left few comments, please address them. Most importantly, since this is an effort to rename "master" to "control plane", we have to make sure there are no "master" left over, can you double check once for this entire page?

content/id/docs/concepts/architecture/control-plane-node-communication.md Outdated

Komponen-komponen master juga berkomunikasi dengan apiserver melalui port yang aman di dalam klaster.
Akibatnya, untuk konfigurasi yang umum dan standar, semua koneksi dari klaster (node-node dan pod-pod yang berjalan di atas node tersebut) menuju master sudah terhubung dengan aman.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an effort to rename master to control plane, we should replace all remaining master as well, can you double check the entire page?

Suggested change
Akibatnya, untuk konfigurasi yang umum dan standar, semua koneksi dari klaster (node-node dan pod-pod yang berjalan di atas node tersebut) menuju master sudah terhubung dengan aman.
Akibatnya, untuk konfigurasi yang umum dan standar, semua koneksi dari klaster (Node-Node dan Pod-Pod yang berjalan di atas Node tersebut) menuju _control plane_ sudah terhubung dengan aman.

content/id/docs/concepts/architecture/control-plane-node-communication.md Outdated

Komponen-komponen master juga berkomunikasi dengan apiserver melalui port yang aman di dalam klaster.
Akibatnya, untuk konfigurasi yang umum dan standar, semua koneksi dari klaster (node-node dan pod-pod yang berjalan di atas node tersebut) menuju master sudah terhubung dengan aman.
Dan juga, klaster dan master bisa terhubung melalui jaringan publik dan/atau yang tak terpercaya (<i>untrusted</i>).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dan juga, klaster dan master bisa terhubung melalui jaringan publik dan/atau yang tak terpercaya (<i>untrusted</i>).
Dan juga, klaster dan _control plane_ bisa terhubung melalui jaringan publik dan/atau yang tak terpercaya (<i>untrusted</i>).

@girikuncoro
Copy link
Contributor

/assign

@irvifa irvifa force-pushed the id/control-plane-node-communication branch from 79d9834 to c1be534 Compare July 4, 2020 07:45
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2020
@irvifa irvifa force-pushed the id/control-plane-node-communication branch from 9b79834 to 5d0d9b4 Compare July 4, 2020 12:27
@irvifa
chore: Migrate existing master-node-communication to control-plane-no…
ece4828 
…de-communication

In this commmit I migrate the former to later and add more information about Konnectivity.
@irvifa irvifa force-pushed the id/control-plane-node-communication branch from 5d0d9b4 to ece4828 Compare July 4, 2020 12:28
@girikuncoro
Copy link
Contributor

Thanks for doing this @irvifa, the change matters a lot for inclusivity in the community

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 436afaa into kubernetes:master Jul 5, 2020
@irvifa irvifa deleted the id/control-plane-node-communication branch July 9, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wahyuoi wahyuoi wahyuoi requested changes

@girikuncoro girikuncoro girikuncoro requested changes

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irvifa @wahyuoi @girikuncoro @k8s-ci-robot