Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom-resource-definitions.md #22822

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Update custom-resource-definitions.md #22822

merged 2 commits into from
Aug 18, 2020

Conversation

mokua
Copy link
Contributor

@mokua mokua commented Jul 30, 2020

The example on line 746-754 has an image tag; with the image tag, the validation will fail with the error "validating data: ValidationError(CronTab.spec): unknown field "image"". Solution : Adding the image field on the CustomResourceDefinitions.

@mokua
Update custom-resource-definitions.md
1c76afc 
The example on line 746-754, should has an image tag; with the image tag, the validation will fail with the error "validating data: ValidationError(CronTab.spec): unknown field "image"".  Solution : Adding the image field on the CustomResourceDefinitions.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jul 30, 2020
@k8s-ci-robot k8s-ci-robot requested review from liggitt and sttts July 30, 2020 06:12
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2020
@netlify
Copy link

netlify bot commented Jul 30, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4719ff5

https://deploy-preview-22822--kubernetes-io-master-staging.netlify.app

@jimangel
Copy link
Member

jimangel commented Aug 1, 2020

It seems like an error of ValidationError(CronTab.spec): unknown field "image" would indicate that the field was specified unnecessarily.

👋 @kubernetes/sig-api-machinery-api-reviews would it be possible to get a technical /lgtm on this minor change? Thanks!

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Aug 1, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@kbhawkey
Copy link
Contributor

kbhawkey commented Aug 4, 2020

Ping @sttts . Would you have time to review this change? Thank you.

lavalamp
lavalamp reviewed Aug 4, 2020
View reviewed changes
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md Outdated
@@ -673,6 +673,8 @@ spec:
cronSpec:
type: string
pattern: '^(\d+|\*)(/\d+)?(\s+(\d+|\*)(/\d+)?){4}$'
image:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing is wrong on this line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mokua , Would you fix the indentation at line 676. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbhawkey done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mokua . One more request: Are you able to rebase to one commit?

@lavalamp
Copy link
Member

lavalamp commented Aug 4, 2020

I think it's fine to fix the problem either by adding this or removing the reference.

@mokua
Update custom-resource-definitions.md
4719ff5 
Fixed indentation on line 676
@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 143405e into kubernetes:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@kbhawkey kbhawkey kbhawkey left review comments

@liggitt liggitt Awaiting requested review from liggitt

@sttts sttts Awaiting requested review from sttts

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mokua @jimangel @fejta-bot @kbhawkey @lavalamp @zacharysarah @k8s-ci-robot