Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID localization for task/dns-debugging-resolution #22907

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Add ID localization for task/dns-debugging-resolution #22907

merged 1 commit into from
Aug 18, 2020

Conversation

danninov
Copy link
Contributor

@danninov danninov commented Aug 2, 2020

Add ID localization for dns-debugging-resolution. Issue #22296

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2020
@k8s-ci-robot k8s-ci-robot added the language/id Issues or PRs related to Indonesian language label Aug 2, 2020
@k8s-ci-robot k8s-ci-robot requested a review from irvifa August 2, 2020 10:07
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2020
@netlify
Copy link

netlify bot commented Aug 2, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 28daaa4

https://deploy-preview-22907--kubernetes-io-master-staging.netlify.app

@danninov
Copy link
Contributor Author

danninov commented Aug 2, 2020

/cc @wahyuoi @irvifa

@k8s-ci-robot k8s-ci-robot requested a review from wahyuoi August 2, 2020 12:07
Copy link
Contributor

@ariscahyadi ariscahyadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danninov for the very good translation. I learned some new Indonesia words from you.
But I have several comments to address.

Copy link
Contributor

@ariscahyadi ariscahyadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it is good to go!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@irvifa
Copy link
Member

irvifa commented Aug 18, 2020

Thanks 🎉
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit cc677c8 into kubernetes:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants