Remove Master/Slave terminology from stateless application tutorial.

[paulczar]

The stateless application tutorial is littered with unsuitable terminology. This update switches the database technology to a database that has already updated their own terminology as well as removes the terminology from the tutorial itself.

The advanced logging tutorial followup is set to Draft as it will take a larger effort to convert that, and I'm not convinced its even in a working state right now.

A followup PR to the examples repo is here - kubernetes/examples#393

Addresses #22918 #19821 and #20088

Signed-off-by: Paul Czarkowski username.taken@gmail.com

[paulczar]

We need a more appropriate place to host the built docker image as I don't have access to the original google repository, and it shouldn't be hosted in my personal one.

[sftim]

This looks like a work-in-progress (not yet ready for review) - is that right @paulczar ?

[sftim]

BTW, Redis uses the term “replica” in place of the problematic word “slave”.

[paulczar]

@sftim I would call it ready for review. There's only really the outstanding issue of needing a forever home for the image which I'll work with @castrojo on, otherwise review away.

[netlify]

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f7a4acf

https://deploy-preview-22934--kubernetes-io-master-staging.netlify.app

[sftim]

I'm worried that the removal will break existing links to the Redis manifests. I'd like to make sure that these still work or that we've made sure they aren't referenced from elsewhere.

/hold

waiting for the revised container image to be hosted as part of the Kubernetes project

[sftim]

This does need to change.

[kbhawkey]

There is also these manifest changes

[notchairmk]

it seems like the correct image would be image: gcr.io/google-samples/gb-frontend:v5. image version was updated here https://console.cloud.google.com/gcr/images/google-samples/GLOBAL/gb-frontend around the same time of this initial PR

[kbhawkey]

@notchairmk, OK. Is this image publicly available?

[notchairmk]

@kbhawkey yes, publicly available. Although, gcr.io/google-samples/gb-frontend:v5 seems more tied to redis, but relies on a slightly different configuration.

I built the guestbook app from Paul's dockerfile PR'd against kubernetes/examples. Unfortunately with that image the guestbook app doesn't appear to run correctly (specifically I'm currently experiencing data duplication on submit).

For both of these reasons, it might be preferable to stay with redis gcr.io/google-samples/gb-frontend:v4 and update file/naming terminology to leader/follow.

[celestehorgan]

/wg naming

[justaugustus]

/assign
(request from @castrojo)

[k8s-ci-robot]

@paulczar: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[castrojo]

@justaugustus Any word on where can host that container image?

[justaugustus]

@ameukam merged a PR to create a staging repository which can house these images: kubernetes/k8s.io#1299 (ref: #22515, kubernetes/k8s.io#1033).

It sounds like the next bit would be wiring up the k/examples repo to do image building and support PRs like kubernetes/examples#393 (ref: #22918).

[ameukam]

We can also setup a dedicated staging container registry for those images. I am happy to help if there is any need!

[paulczar]

I'd love to take some help if people are offering, I don't have a lot of time over the next few weeks to work on this.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign xiangpengzhao after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiangpengzhao in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kbhawkey]

Hi @paulczar . Just checking on the status of the pull request?
Do you still plan to replace Redis with MongoDB?
What work is remaining to get this PR closer to be ready for review?

[paulczar]

hey @kbhawkey I probably need to take some time to implement @justaugustus suggestions above, This week is already toast for me, hopefully next week I can focus on this for a day and get it closed out.

[kbhawkey]

hey @kbhawkey I probably need to take some time to implement @justaugustus suggestions above, This week is already toast for me, hopefully next week I can focus on this for a day and get it closed out.

Thanks for the update!

[justaugustus]

I'm going to look into some of this this week.

[onlydole]

Thank you, @justaugustus! I'll be free next week if you need anything extra on this front.

[sftim]

Some extra context: #25704

[bdwill]

I went through the tutorial and it worked well. I have a few comments:

Creating the Mongo Deployment

• Step 3 listed as step 1
• Step 4 listed as step 2. In this step, I suggest commenting why this step is being performed or add (optional)

Creating the MongoDB Service

• Step 2 listed as step 1
• Output from kubectl get service needs to be updated to reflect port 27017 for mongodb

Creating the Guestbook Frontend Deployment

• Step 2 listed as step 1
• Step 2 command needs to be updated to reflect correct labels: kubectl get pods -l app.kubernetes.io/component=frontend -l app.kubernetes.io/name=guestbook

Creating the Frontend Service

• Word missing in last sentence. Correct: "However as a Kubernetes user you can use kubectl port-forward to access the service even though it uses a ClusterIP."
• Step 2 listed as step 1
• Update output from kubectl get services to reflect correct mongodb port 27017

Viewing the Frontend Service via kubectl port-forward

• Indicate that kubectl port-forward should be performed in a separate window or exited with control+C to complete the rest of the tutorial

[TheKLARKEN]

I have a few notes for things I've noticed:

• I’m not sure if this is the preview site's fault, because this happens all over the site, but clicking the “copy to clipboard” in the preview (link) copies not just the YAML but also the name and path next to the copy button. The current docs don't do this, just the preview site. This behavior may cause some users to be confused by YAML parsing errors like line 3: mapping values are not allowed in this context, because they aren’t aware that they need to remove the first line that gets pasted.
• The numbers of the steps don’t go 1, 2, 3, etc. like they should, they go 1, 1, 1, etc. or 1, 2, 1, 2, etc. in some places.
• kubectl get pods -l app=guestbook -l tier=frontend doesn’t return the correct result, because the pods are labeled like this:

  • labels:
      app.kubernetes.io/name: guestbook
      app.kubernetes.io/component: frontend

• In “Viewing the Frontend Service via LoadBalancer,” TYPE should return LoadBalancer, not ClusterIP.
• In “Cleaning up,” users should probably also check services, not just pods, to show that everything is deleted (e.g. ‘kubectl get svc,po’).

Everything else looked good. 🙂

[paulczar]

thanks folks for the reviews, I'm waiting to hear back on image storage before I get back to this, but rest assured its not forgotten.

[kbhawkey]

Hi @paulczar .
Since PR #26141 merged, can this PR close?

[justaugustus]

Since PR #26141 merged, can this PR close?

Yep!
/close

[k8s-ci-robot]

@justaugustus: Closed this PR.

In response to this:

Since PR #26141 merged, can this PR close?

Yep!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.