-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up analytics in footer #22998
clean up analytics in footer #22998
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 0898f1c https://deploy-preview-22998--kubernetes-io-master-staging.netlify.app |
/area web-development |
At this stage, if the link target is not working properly, commenting the link out might be the best option. |
I'd like more information about the purpose of this pixel with regard to the site analytics. |
@kbhawkey, I may be wrong but my theory is that this link is used to count page visits. On the link target, you can sum up the visits by checking the page referrer. |
/approve /hold Is this the tool in use? https://github.com/igrigorik/ga-beacon |
I don't know about the "ga-beacon" tool, but the description of the tool fits. |
It seems that this update has already done on June 24 by this PR: igrigorik/ga-beacon/pull/69. So just fetching source code and redeploy it to App Engine is enough? |
@celestehorgan do you have any context about that beacon and its operation? |
Great! @zacharysarah @jimangel @kbarnard10 do you have insight into updating the docs code to GAE? |
@sftim no I don't, unfortunately. Judging by its position (not in the footer but specifically in I don't have access to the Analytics so I can't say more. |
I went deep down this rabbit hole... It looks like something that was implemented around 2015 as a way to track analytics of GitHub markdown files (the literal files when viewed on GitHub). You can read more about ga-beacon in the repo linked above. Also, looking at the file's git history and following it back to the earliest file, it came over as part of the Jekyll migration. From everything I can find, this was somewhat an early attempt at gaining analytics that are not commonly known on GitHub. Given that we still implement the Google Analytics JS over the entire site and the fact that this GAE app is broken (and not intended to improve the website). I think it's safe to remove. I would prefer the entire section gets deleted vs. commented out. /cc @zacharysarah |
+1 to removing this completely. Thanks for the research, @jimangel! |
That's fine. I will update. |
eb176f4
to
0898f1c
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
See issue #22819 .