Fix CRI-O installation information #23000

haircommander · 2020-08-06T20:47:41Z

update Ubuntu, CentOS and Debian installation instructions
add Fedora instructions

k8s-ci-robot · 2020-08-06T20:47:49Z

Welcome @haircommander!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

haircommander · 2020-08-06T20:48:54Z

PTAL @TomSweeneyRedHat

netlify · 2020-08-06T20:59:58Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ed4506c

https://deploy-preview-23000--kubernetes-io-master-staging.netlify.app

TomSweeneyRedHat · 2020-08-06T21:12:18Z

content/en/docs/setup/production-environment/container-runtimes.md

+<br />
+Then, set `$VERSION` to be the cri-o version matching your kubernetes version.                                                                                                                                                                
+For instance, if you want to install cri-o 1.17, `VERSION=1.17`                                                                                                                                                                               
+We also support pinning to a particular release. To install 1.17.3, `VERSION=1.17:1.17.3`


is 1.17 the latest on CENTOS? If 1.18 is, I'd bump this example

TomSweeneyRedHat · 2020-08-06T21:14:17Z

One question, otherwise LGTM

kbhawkey · 2020-08-07T16:09:24Z

Page preview:
https://deploy-preview-23000--kubernetes-io-master-staging.netlify.app/docs/setup/production-environment/container-runtimes/

content/en/docs/setup/production-environment/container-runtimes.md

kbhawkey · 2020-08-08T12:17:44Z

content/en/docs/setup/production-environment/container-runtimes.md

+| Centos 8         | `CentOS_8`        |
+| Centos 8 Stream  | `CentOS_8_Stream` |
+| Centos 7         | `CentOS_7`        |
+<br />


Is the <br> required to provide spacing between the table and the following text?

haircommander · 2020-08-10T16:26:09Z

addressed as suggested @kbhawkey PTAL

inductor · 2020-08-11T07:04:57Z

@haircommander

Is this design intended? looks kinda weird to me 🤔

haircommander · 2020-08-11T13:00:23Z

If I'm being honest, the table format is not being rendered super well. I think it is clear enough to be understood, but I'm happy to adopt a change that would look better.

kbhawkey · 2020-08-11T14:10:28Z

content/en/docs/setup/production-environment/container-runtimes.md

+| Ubuntu 19.10     | `xUbuntu_19.10`   |
+| Ubuntu 19.04     | `xUbuntu_19.04`   |
+| Ubuntu 18.04     | `xUbuntu_18.04`   |
+<br />


Hi @haircommander .
I suspect the parser is not happy with the <br> elements.
What happens if these are removed? Is there no spacing after the table
and before the next line of text?

yeah the table comes immediately before. It definitely looks weird. I can push an updated version if you'd like

lmk what you think, I left it as a separate commit to be easily reverted. I think the oddly spaced out table is better

actually, I updated the version, adding a newline between br and the table. that fixed the issue

Thanks @haircommander. The tables look good.

kbhawkey · 2020-08-12T14:23:17Z

/lgtm

zacharysarah

@haircommander 👋 Thanks for the update! Please follow the style guide, specifically:

Capitalize consistently
Avoid "we"
Use in-line code formatting

zacharysarah · 2020-08-16T21:11:53Z

content/en/docs/setup/production-environment/container-runtimes.md

+{{% /tab %}}
+{{% tab name="Fedora" %}}
+
+Set `$VERSION` to be the cri-o version matching your kubernetes version.                                                                                                                                                                


Suggested change

Set `$VERSION` to be the cri-o version matching your kubernetes version.

Set `$VERSION` to the CRI-O version that matches your Kubernetes version.

zacharysarah · 2020-08-16T21:11:57Z

content/en/docs/setup/production-environment/container-runtimes.md

+{{% tab name="Fedora" %}}
+
+Set `$VERSION` to be the cri-o version matching your kubernetes version.                                                                                                                                                                
+For instance, if you want to install cri-o 1.18, `VERSION=1.18`                                                                                                                                                                               


Capitalize consistently.

Suggested change

For instance, if you want to install cri-o 1.18, `VERSION=1.18`

For instance, if you want to install CRI-O 1.18, `VERSION=1.18`

zacharysarah · 2020-08-16T21:12:31Z

content/en/docs/setup/production-environment/container-runtimes.md

+```shell
+dnf module list cri-o
+```
+We do not support pinning to specific releases on Fedora.


Avoid using "we".

Suggested change

We do not support pinning to specific releases on Fedora.

CRI-O does not support pinning to specific releases on Fedora.

zacharysarah · 2020-08-16T21:14:02Z

content/en/docs/setup/production-environment/container-runtimes.md

-echo 'deb http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_Unstable/ /' > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list
-wget -nv https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/Debian_Unstable/Release.key -O- | sudo apt-key add -
-```
+To install CRI-O on the following operating systems, set the environment variable $OS as the appropriate field in the following table:


Use code format for inline code.

Suggested change

To install CRI-O on the following operating systems, set the environment variable $OS as the appropriate field in the following table:

To install CRI-O on the following operating systems, set the environment variable $OS to the appropriate field in the following table:

zacharysarah · 2020-08-16T21:14:26Z

content/en/docs/setup/production-environment/container-runtimes.md

-wget -nv https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/Debian_10/Release.key -O- | sudo apt-key add -
-```
+<br />
+Then, set `$VERSION` to be the cri-o version matching your kubernetes version.


Capitalize consistently.

Suggested change

Then, set `$VERSION` to be the cri-o version matching your kubernetes version.

Then, set `$VERSION` to be the CRI-O version matching your kubernetes version.

zacharysarah · 2020-08-16T21:16:11Z

content/en/docs/setup/production-environment/container-runtimes.md

+| Ubuntu 18.04     | `xUbuntu_18.04`   |
+
+<br />
+Then, set `$VERSION` to be the cri-o version matching your kubernetes version.


Suggested change

Then, set `$VERSION` to be the cri-o version matching your kubernetes version.

Then, set `$VERSION` to the CRI-O version that matches your Kubernetes version.

zacharysarah · 2020-08-16T21:16:27Z

content/en/docs/setup/production-environment/container-runtimes.md

+
+<br />
+Then, set `$VERSION` to be the cri-o version matching your kubernetes version.
+For instance, if you want to install cri-o 1.18, set `VERSION=1.18`.


Capitalize consistently.

Suggested change

For instance, if you want to install cri-o 1.18, set `VERSION=1.18`.

For instance, if you want to install CRI-O 1.18, set `VERSION=1.18`.

zacharysarah · 2020-08-16T21:16:44Z

content/en/docs/setup/production-environment/container-runtimes.md

-curl -L -o /etc/yum.repos.d/devel:kubic:libcontainers:stable.repo https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/CentOS_7/devel:kubic:libcontainers:stable.repo
-curl -L -o /etc/yum.repos.d/devel:kubic:libcontainers:stable:cri-o:{{< skew latestVersion >}}.repo https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable:cri-o:{{< skew latestVersion >}}/CentOS_7/devel:kubic:libcontainers:stable:cri-o:{{< skew latestVersion >}}.repo
-```
+To install on the following operating systems, set the environment variable $OS as the appropriate field in the following table:


Suggested change

To install on the following operating systems, set the environment variable $OS as the appropriate field in the following table:

To install CRI- O on the following operating systems, set the environment variable $OS as the appropriate field in the following table:

zacharysarah · 2020-08-16T21:17:20Z

content/en/docs/setup/production-environment/container-runtimes.md

+| Centos 7         | `CentOS_7`        |
+
+<br />
+Then, set `$VERSION` to be the cri-o version matching your kubernetes version.


Capitalize consistently.

Suggested change

Then, set `$VERSION` to be the cri-o version matching your kubernetes version.

Then, set `$VERSION` to the CRI-O version that matches your Kubernetes version.

zacharysarah · 2020-08-16T21:17:32Z

content/en/docs/setup/production-environment/container-runtimes.md

+
+<br />
+Then, set `$VERSION` to be the cri-o version matching your kubernetes version.
+For instance, if you want to install cri-o 1.18, set `VERSION=1.18`.


Suggested change

For instance, if you want to install cri-o 1.18, set `VERSION=1.18`.

For instance, if you want to install CRI-O 1.18, set `VERSION=1.18`.

update Ubuntu, CentOS and Debian installation instructions add Fedora instructions Signed-off-by: Peter Hunt <pehunt@redhat.com>

haircommander · 2020-08-17T19:06:33Z

thank you @zacharysarah, updated as suggested

zacharysarah · 2020-08-17T20:31:25Z

/lgtm
/approve

k8s-ci-robot · 2020-08-17T20:32:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [zacharysarah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2020

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2020

k8s-ci-robot requested review from bart0sh and vincepri August 6, 2020 20:48

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 6, 2020

haircommander mentioned this pull request Aug 6, 2020

cri-o v1.18.x is not available on Ubuntu? cri-o/cri-o#3844

Closed

TomSweeneyRedHat reviewed Aug 6, 2020

View reviewed changes

haircommander force-pushed the fix-crio-docs branch from 7104f98 to a41249b Compare August 7, 2020 16:45

kbhawkey reviewed Aug 8, 2020

View reviewed changes

content/en/docs/setup/production-environment/container-runtimes.md Outdated Show resolved Hide resolved

kbhawkey reviewed Aug 8, 2020

View reviewed changes

content/en/docs/setup/production-environment/container-runtimes.md Outdated Show resolved Hide resolved

kbhawkey reviewed Aug 8, 2020

View reviewed changes

haircommander force-pushed the fix-crio-docs branch from a41249b to c061bde Compare August 10, 2020 16:25

haircommander mentioned this pull request Aug 10, 2020

cri-o 1.17 doesn't install on RHEL 7.7 - Package does not match intended download cri-o/cri-o#4050

Closed

inductor requested a review from kbhawkey August 11, 2020 07:00

kbhawkey reviewed Aug 11, 2020

View reviewed changes

haircommander force-pushed the fix-crio-docs branch from 78d1e97 to 36eefba Compare August 11, 2020 15:54

k8s-ci-robot assigned kbhawkey Aug 12, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020

zacharysarah suggested changes Aug 16, 2020

View reviewed changes

Fix CRI-O installation information

ed4506c

update Ubuntu, CentOS and Debian installation instructions add Fedora instructions Signed-off-by: Peter Hunt <pehunt@redhat.com>

haircommander force-pushed the fix-crio-docs branch from 36eefba to ed4506c Compare August 17, 2020 19:06

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2020

k8s-ci-robot assigned zacharysarah Aug 17, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2020

k8s-ci-robot merged commit 46ba002 into kubernetes:master Aug 17, 2020

icpenguins mentioned this pull request Dec 16, 2020

CANNOT INSTALL PER DOCS on Ubuntu 20.04 cri-o/cri-o#4436

Closed

haircommander mentioned this pull request Jan 27, 2021

REQUEST: New membership for haircommander kubernetes/org#2463

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CRI-O installation information #23000

Fix CRI-O installation information #23000

haircommander commented Aug 6, 2020

k8s-ci-robot commented Aug 6, 2020

haircommander commented Aug 6, 2020

netlify bot commented Aug 6, 2020 •

edited

Loading

TomSweeneyRedHat Aug 6, 2020

haircommander Aug 7, 2020

TomSweeneyRedHat commented Aug 6, 2020

kbhawkey commented Aug 7, 2020

kbhawkey Aug 8, 2020

haircommander Aug 10, 2020

haircommander commented Aug 10, 2020

inductor commented Aug 11, 2020

haircommander commented Aug 11, 2020

kbhawkey Aug 11, 2020

haircommander Aug 11, 2020

haircommander Aug 11, 2020

haircommander Aug 11, 2020

kbhawkey Aug 12, 2020

kbhawkey commented Aug 12, 2020

zacharysarah left a comment

zacharysarah Aug 16, 2020

zacharysarah Aug 16, 2020

zacharysarah Aug 16, 2020

zacharysarah Aug 16, 2020

zacharysarah Aug 16, 2020

zacharysarah Aug 16, 2020

zacharysarah Aug 16, 2020

zacharysarah Aug 16, 2020

zacharysarah Aug 16, 2020

zacharysarah Aug 16, 2020

haircommander commented Aug 17, 2020

zacharysarah commented Aug 17, 2020

k8s-ci-robot commented Aug 17, 2020

	Set `$VERSION` to be the cri-o version matching your kubernetes version.
	Set `$VERSION` to the CRI-O version that matches your Kubernetes version.

	For instance, if you want to install cri-o 1.18, `VERSION=1.18`
	For instance, if you want to install CRI-O 1.18, `VERSION=1.18`

	We do not support pinning to specific releases on Fedora.
	CRI-O does not support pinning to specific releases on Fedora.

	To install CRI-O on the following operating systems, set the environment variable $OS as the appropriate field in the following table:
	To install CRI-O on the following operating systems, set the environment variable $OS to the appropriate field in the following table:

	Then, set `$VERSION` to be the cri-o version matching your kubernetes version.
	Then, set `$VERSION` to be the CRI-O version matching your kubernetes version.

	Then, set `$VERSION` to be the cri-o version matching your kubernetes version.
	Then, set `$VERSION` to the CRI-O version that matches your Kubernetes version.

	To install on the following operating systems, set the environment variable $OS as the appropriate field in the following table:
	To install CRI- O on the following operating systems, set the environment variable $OS as the appropriate field in the following table:

Fix CRI-O installation information #23000

Fix CRI-O installation information #23000

Conversation

haircommander commented Aug 6, 2020

k8s-ci-robot commented Aug 6, 2020

haircommander commented Aug 6, 2020

netlify bot commented Aug 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomSweeneyRedHat commented Aug 6, 2020

kbhawkey commented Aug 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

haircommander commented Aug 10, 2020

inductor commented Aug 11, 2020

haircommander commented Aug 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbhawkey commented Aug 12, 2020

zacharysarah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

haircommander commented Aug 17, 2020

zacharysarah commented Aug 17, 2020

k8s-ci-robot commented Aug 17, 2020

netlify bot commented Aug 6, 2020 •

edited

Loading