Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate 2018-04-25-open-source-charts-2017.md #23099

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Translate 2018-04-25-open-source-charts-2017.md #23099

merged 2 commits into from
Aug 18, 2020

Conversation

yixin21
Copy link
Contributor

@yixin21 yixin21 commented Aug 12, 2020

zh-trans 2018-04-25-open-source-charts-2017.md

ref:k8smeetup/website-tasks#3242

@yixin21
Create 2018-04-25-open-source-charts-2017.md
314b43e 
zh-trans 2018-04-25-open-source-charts-2017.md
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2020
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 12, 2020
@yixin21
Copy link
Contributor Author

yixin21 commented Aug 12, 2020

/assign @zacharysarah

@netlify
Copy link

netlify bot commented Aug 12, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 60d18f7

https://deploy-preview-23099--kubernetes-io-master-staging.netlify.app

@zacharysarah
Copy link
Contributor

@yixin21 Please assign another Chinese localization contributor for review:

website/OWNERS_ALIASES

Line 161 in c8c2f69

sig-docs-zh-reviews: # PR reviews for Chinese content

/unassign
cc @kubernetes/sig-docs-zh-reviews

markthink
markthink reviewed Aug 16, 2020
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2020
@yixin21 @tengqm
Update content/zh/blog/_posts/2018-04-25-open-source-charts-2017.md
60d18f7 
Co-authored-by: Qiming Teng <tengqim@cn.ibm.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@tengqm
Copy link
Contributor

tengqm commented Aug 18, 2020

/lgtm
/approve
/tide-merge-method squash

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7b2d09a into kubernetes:master Aug 18, 2020
@tengqm tengqm mentioned this pull request Aug 18, 2020
Closed
@sftim sftim mentioned this pull request Aug 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markthink markthink markthink left review comments

@tengqm tengqm tengqm requested changes

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@markthink markthink

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yixin21 @zacharysarah @tengqm @k8s-ci-robot @markthink