Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Creating a single control-plane cluster with kubeadm #23114

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Update Creating a single control-plane cluster with kubeadm #23114

merged 1 commit into from
Aug 13, 2020

Conversation

RA489
Copy link

@RA489 RA489 commented Aug 13, 2020

Updated Creating a single control-plane cluster with kubeadm
fixes: #23067

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2020
@k8s-ci-robot k8s-ci-robot requested a review from sftim August 13, 2020 09:36
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 13, 2020
@netlify
Copy link

netlify bot commented Aug 13, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5a88063

https://deploy-preview-23114--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Aug 13, 2020

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Aug 13, 2020
neolit123
neolit123 reviewed Aug 13, 2020
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @RA489

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2020
@sftim
Copy link
Contributor

sftim commented Aug 13, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 260a628 into kubernetes:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@sftim sftim Awaiting requested review from sftim

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page title “Creating a single control-plane cluster with kubeadm” could mislead
4 participants
@RA489 @sftim @k8s-ci-robot @neolit123