Actuallize podresources description #24641

AlexeyPerevalov · 2020-10-19T15:38:21Z

This commit updates description according to
kubernetes/enhancements#1884

/milestone 1.20
Issue: kubernetes/enhancements#2043

Signed-off-by: Alexey Perevalov alexey.perevalov@huawei.com

k8s-ci-robot · 2020-10-19T15:38:27Z

@AlexeyPerevalov: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

This commit updates description according to
kubernetes/enhancements#1884

/milestone 1.20

Signed-off-by: Alexey Perevalov alexey.perevalov@huawei.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8sio-netlify-preview-bot · 2020-10-19T15:38:31Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit b61e575

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fab959b5a8ef10008f1d103

reylejano · 2020-10-19T15:50:53Z

/milestone 1.20

kbhawkey · 2020-10-20T18:39:00Z

/cc @annajung

irvifa · 2020-10-20T22:11:12Z

/sig architecture

sftim

This makes sense to me. I haven't really checked the gRPC details though.
As this page is getting long, I wonder if it makes sense to move that gRPC service description within https://k8s.io/reference/ ?

(if you agree - we can do that move as a second PR against dev-1.20)

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

sftim · 2020-10-20T22:30:09Z

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

+
+```gRPC
+
+// WatchPodResourcesRequest is the request made to the Watch PodResourcesLister service


PodResourcesLister or PodResources?

Good question. In both KEP (https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2043-pod-resource-concrete-assigments, https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/606-compute-device-assignment) PodResources was used, but in implementation PodResourcesLister is used now.
Documentation should be written according to implementation.
But what to do with KEP, rename it there?

Yes, feel free to update the KEP as well

AlexeyPerevalov · 2020-10-21T07:18:43Z

This makes sense to me. I haven't really checked the gRPC details though.
As this page is getting long, I wonder if it makes sense to move that gRPC service description within https://k8s.io/reference/ ?

(if you agree - we can do that move as a second PR against dev-1.20)

I had the same think when edited. I thought it's reasonable to move PodResorcesLister section into new file. But what is it - https://k8s.io/reference/? Is it https://kubernetes.io/docs/reference/?

AlexeyPerevalov · 2020-10-21T19:15:38Z

/cc @dashpole

reylejano · 2020-10-27T16:05:55Z

/remove-sig architecture
/sig node
/hold
waiting for kubernetes/kubernetes#93243 to merge

AlexeyPerevalov · 2020-10-27T16:21:20Z

/remove-sig architecture
/sig node
/hold
waiting for kubernetes/kubernetes#93243 to merge

Not only PR 93243, but also in this PR was mentioned API from kubernetes/kubernetes#95734.
Both should be merged.

annajung · 2020-10-27T17:09:11Z

/hold
pending kubernetes/kubernetes#93243 and kubernetes/kubernetes#95734

k8s-ci-robot · 2020-11-03T11:28:35Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kbhawkey after the PR has been reviewed.
You can assign the PR to them by writing /assign @kbhawkey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

annajung · 2020-11-05T21:16:05Z

/assign @reylejano-rxm

sftim · 2020-11-10T18:47:52Z

Hi @AlexeyPerevalov

Would you have a chance to rebase this against dev-1.20? It's currently got a merge conflict.

kbhawkey · 2020-11-10T19:04:16Z

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

@@ -204,7 +259,7 @@ DaemonSet, `/var/lib/kubelet/pod-resources` must be mounted as a
 {{< glossary_tooltip term_id="volume" >}} in the plugin's
 [PodSpec](/docs/reference/generated/kubernetes-api/{{< param "version" >}}/#podspec-v1-core).

-Support for the "PodResources service" requires `KubeletPodResources` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to be enabled. It is enabled by default starting with Kubernetes 1.15.
+Support for the "PodResourcesLister service" requires `KubeletPodResources` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to be enabled. It is enabled by default starting with Kubernetes 1.15.


nit: You can remove the double quotes around, PodResourceLister service ...
and possibly format the name of the service with single back quotes,
PodResourcesLister?

kbhawkey · 2020-11-10T19:07:42Z

content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md

@@ -193,9 +193,64 @@ for these devices:
 // node resources consumed by pods and containers on the node
 service PodResourcesLister {
    rpc List(ListPodResourcesRequest) returns (ListPodResourcesResponse) {}
+    rpc GetAllocatableResources(AllocatableResourcesRequest) returns (AllocatableResourcesResponse) {}


This is an API offered by the kubelet? gRPC only?

irvifa · 2020-11-10T19:20:47Z

/retest

This commit updates description according to kubernetes/enhancements#1884 Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>

…/device-plugins.md Co-authored-by: Tim Bannister <tim@scalefactory.com>

irvifa · 2020-11-13T13:31:44Z

/hold cancel

irvifa · 2020-11-13T13:33:12Z

/hold
pending kubernetes/kubernetes#95734

irvifa · 2020-11-13T13:34:22Z

Hi @AlexeyPerevalov Since the code freeze is on effect, wondering if folks raise exception for this since one of the PR is not merged yet

annajung · 2020-11-13T14:09:24Z

Note:

Exception filed (pending approval)

annajung · 2020-11-13T14:10:40Z

/hold

annajung · 2020-11-16T15:04:17Z

Exception request has been denied for this enhancement.

/milestone clear
/close

k8s-ci-robot · 2020-11-16T15:04:31Z

@annajung: Closed this PR.

In response to this:

Exception request has been denied for this enhancement.

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2020

k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 19, 2020

k8s-ci-robot requested review from jimangel and kbarnard10 October 19, 2020 15:38

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2020

AlexeyPerevalov mentioned this pull request Oct 19, 2020

Ability to list/watch for concrete resource assignments via PodResource API kubernetes/enhancements#2043

Closed

k8s-ci-robot added this to the 1.20 milestone Oct 19, 2020

k8s-ci-robot requested a review from annajung October 20, 2020 18:39

k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Oct 20, 2020

sftim reviewed Oct 20, 2020

View reviewed changes

AlexeyPerevalov force-pushed the PodResourcesEnhancements branch from 0317f94 to 3de9794 Compare October 21, 2020 07:55

k8s-ci-robot requested a review from dashpole October 21, 2020 19:15

k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Oct 27, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020

AlexeyPerevalov force-pushed the PodResourcesEnhancements branch from 3de9794 to edb0eb8 Compare November 3, 2020 11:28

k8s-ci-robot assigned reylejano Nov 5, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2020

kbhawkey reviewed Nov 10, 2020

View reviewed changes

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2020

AlexeyPerevalov and others added 3 commits November 11, 2020 10:33

Actuallize podresources description

18e57ad

This commit updates description according to kubernetes/enhancements#1884 Signed-off-by: Alexey Perevalov <alexey.perevalov@huawei.com>

Update content/en/docs/concepts/extend-kubernetes/compute-storage-net…

160b43b

…/device-plugins.md Co-authored-by: Tim Bannister <tim@scalefactory.com>

Update content/en/docs/concepts/extend-kubernetes/compute-storage-net…

b61e575

…/device-plugins.md Co-authored-by: Tim Bannister <tim@scalefactory.com>

AlexeyPerevalov force-pushed the PodResourcesEnhancements branch from e2f6f69 to b61e575 Compare November 11, 2020 07:41

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2020

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2020

k8s-ci-robot removed this from the 1.20 milestone Nov 16, 2020

k8s-ci-robot closed this Nov 16, 2020

ffromani mentioned this pull request Mar 24, 2021

Actualize podresources 1.21 #27203

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Actuallize podresources description #24641

Actuallize podresources description #24641

AlexeyPerevalov commented Oct 19, 2020 •

edited

Loading

k8s-ci-robot commented Oct 19, 2020

k8sio-netlify-preview-bot commented Oct 19, 2020 •

edited

Loading

reylejano commented Oct 19, 2020

kbhawkey commented Oct 20, 2020

irvifa commented Oct 20, 2020

sftim left a comment

sftim Oct 20, 2020

AlexeyPerevalov Oct 21, 2020

dashpole Oct 21, 2020

AlexeyPerevalov commented Oct 21, 2020

AlexeyPerevalov commented Oct 21, 2020 •

edited

Loading

reylejano commented Oct 27, 2020 •

edited

Loading

AlexeyPerevalov commented Oct 27, 2020

annajung commented Oct 27, 2020

k8s-ci-robot commented Nov 3, 2020

annajung commented Nov 5, 2020

sftim commented Nov 10, 2020

kbhawkey Nov 10, 2020

kbhawkey Nov 10, 2020

tengqm Nov 11, 2020

irvifa commented Nov 10, 2020

irvifa commented Nov 13, 2020

irvifa commented Nov 13, 2020

irvifa commented Nov 13, 2020

annajung commented Nov 13, 2020

annajung commented Nov 13, 2020

annajung commented Nov 16, 2020

k8s-ci-robot commented Nov 16, 2020


		```gRPC

		// WatchPodResourcesRequest is the request made to the Watch PodResourcesLister service

Actuallize podresources description #24641

Actuallize podresources description #24641

Conversation

AlexeyPerevalov commented Oct 19, 2020 • edited Loading

k8s-ci-robot commented Oct 19, 2020

k8sio-netlify-preview-bot commented Oct 19, 2020 • edited Loading

reylejano commented Oct 19, 2020

kbhawkey commented Oct 20, 2020

irvifa commented Oct 20, 2020

sftim left a comment

Choose a reason for hiding this comment

sftim Oct 20, 2020

Choose a reason for hiding this comment

AlexeyPerevalov Oct 21, 2020

Choose a reason for hiding this comment

dashpole Oct 21, 2020

Choose a reason for hiding this comment

AlexeyPerevalov commented Oct 21, 2020

AlexeyPerevalov commented Oct 21, 2020 • edited Loading

reylejano commented Oct 27, 2020 • edited Loading

AlexeyPerevalov commented Oct 27, 2020

annajung commented Oct 27, 2020

k8s-ci-robot commented Nov 3, 2020

annajung commented Nov 5, 2020

sftim commented Nov 10, 2020

kbhawkey Nov 10, 2020

Choose a reason for hiding this comment

kbhawkey Nov 10, 2020

Choose a reason for hiding this comment

tengqm Nov 11, 2020

Choose a reason for hiding this comment

irvifa commented Nov 10, 2020

irvifa commented Nov 13, 2020

irvifa commented Nov 13, 2020

irvifa commented Nov 13, 2020

annajung commented Nov 13, 2020

annajung commented Nov 13, 2020

annajung commented Nov 16, 2020

k8s-ci-robot commented Nov 16, 2020

AlexeyPerevalov commented Oct 19, 2020 •

edited

Loading

k8sio-netlify-preview-bot commented Oct 19, 2020 •

edited

Loading

AlexeyPerevalov commented Oct 21, 2020 •

edited

Loading

reylejano commented Oct 27, 2020 •

edited

Loading