Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: remove deprecated alpha commands #25935

Merged
merged 1 commit into from
Jan 9, 2021
Merged

kubeadm: remove deprecated alpha commands #25935

merged 1 commit into from
Jan 9, 2021

Conversation

carlory
Copy link
Member

@carlory carlory commented Jan 4, 2021

@k8s-ci-robot k8s-ci-robot added this to the 1.21 milestone Jan 4, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jan 4, 2021 •
edited
Loading

👷 Deploy preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: e4ac283

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5ff91ecf16d19300089ca8ef

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 4, 2021
@carlory carlory mentioned this pull request Jan 4, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2021
neolit123
neolit123 reviewed Jan 4, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sig cluster-lifecycle
thanks for the PR. i've added a few comments.

after you make the changes. please keep the commits squashed to one.

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jan 4, 2021
@carlory carlory mentioned this pull request Jan 5, 2021
Closed
6 tasks
sftim
sftim previously requested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like it needs revising.
See https://github.com/kubernetes/website/pull/25935/files#r551381516

@carlory carlory force-pushed the deprecate-kubeadm-alpha-in-1.21 branch from e78b10e to 6d67709 Compare January 6, 2021 08:52
@carlory
Copy link
Member Author

carlory commented Jan 6, 2021

/assign @neolit123 @sftim

@carlory carlory force-pushed the deprecate-kubeadm-alpha-in-1.21 branch from 6d67709 to 500279d Compare January 6, 2021 09:09
@carlory carlory force-pushed the deprecate-kubeadm-alpha-in-1.21 branch from 500279d to 233c82c Compare January 6, 2021 09:14
@carlory carlory force-pushed the deprecate-kubeadm-alpha-in-1.21 branch from 233c82c to f8b3527 Compare January 6, 2021 09:58
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2021
@carlory carlory changed the title deprecate kubeadm alpha in 1.21 deprecate kubeadm alpha kubeconfig in 1.21 Jan 6, 2021
@carlory carlory requested a review from sftim January 6, 2021 15:39
@sftim sftim dismissed their stale review January 6, 2021 17:03

Superseded

@carlory
Copy link
Member Author

carlory commented Jan 7, 2021

/assign @neolit123

@carlory carlory force-pushed the deprecate-kubeadm-alpha-in-1.21 branch from f8b3527 to 7408d13 Compare January 8, 2021 02:15
@carlory
Copy link
Member Author

carlory commented Jan 8, 2021

/assign @neolit123

neolit123
neolit123 reviewed Jan 8, 2021
View reviewed changes
content/en/docs/reference/setup-tools/kubeadm/kubeadm-alpha.md Outdated
{{< tab name="selfhosting" include="generated/kubeadm_alpha_selfhosting.md" />}}
{{< tab name="pivot" include="generated/kubeadm_alpha_selfhosting_pivot.md" />}}
{{< /tabs >}}
well there is `kubeconfig` but it's deprecated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line, this is what i meant in my previous comment.

@carlory carlory force-pushed the deprecate-kubeadm-alpha-in-1.21 branch from 7408d13 to e4ac283 Compare January 9, 2021 03:11
neolit123
neolit123 reviewed Jan 9, 2021
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 76b82bfd83ef48da547239c12483e52397722ce4

@neolit123
Copy link
Member

/retitle kubeadm: remove deprecated alpha commands

@k8s-ci-robot k8s-ci-robot changed the title deprecate kubeadm alpha kubeconfig in 1.21 kubeadm: remove deprecated alpha commands Jan 9, 2021
@sftim
Copy link
Contributor

sftim commented Jan 9, 2021

This PR is held - is that hold still relevant?

@neolit123
Copy link
Member

This PR is held - is that hold still relevant?

no
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2021
@sftim
Copy link
Contributor

sftim commented Jan 9, 2021

Thanks @carlory & SIG Cluster Lifecycle
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 83879e9 into kubernetes:dev-1.21 Jan 9, 2021
@carlory carlory deleted the deprecate-kubeadm-alpha-in-1.21 branch January 9, 2021 14:35
This was referenced Jan 12, 2021
Closed
Closed
@neolit123 neolit123 mentioned this pull request Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@jimangel jimangel Awaiting requested review from jimangel

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

@sftim sftim Awaiting requested review from sftim

Assignees

@neolit123 neolit123

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@carlory @k8sio-netlify-preview-bot @k8s-ci-robot @neolit123 @sftim