New annotations “kubectl.kubernetes.io/default-container” #27095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 4c51305 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/605439eec6d29e0008c11441 |
k8s-ci-robot
added
language/en
sftim
reviewed
Mar 17, 2021
|
|
||
| Example: `kubectl.kubernetes.io/default-container:container1` | ||
|
|
||
| If a Pod has the annotation `kubectl.kubernetes.io/default-container`, consumers (CLI, operators) know which is the default container. For example, `kubectl logs` or `kubectl exec` without `-c` or `--container` flag will use this default container. |
There was a problem hiding this comment.
- We're listing this in the wrong place (under a heading “The taints listed below are always used on Nodes”)
- We should explicitly say that the value of the annotation is the container name that is default for this Pod.
sftim
reviewed
Mar 17, 2021
|
/sig cli |
k8s-ci-robot
added
the
sig/cli
|
/assign |
pacoxu
changed the title
Co-authored-by: Tim Bannister <tim@scalefactory.com>
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
LGTM (would like someone else to /lgtm) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm From sig-cli perspective Thank you @pacoxu ! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2a157ec136317edb66182d2cb813c8e422321c8c
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes/enhancements#2227 (comment)
It is implemented in 1.21