Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove annotation for Experimental Windows Hyper-v #28965

Merged
merged 3 commits into from
Jul 24, 2021
Merged

Remove annotation for Experimental Windows Hyper-v #28965

merged 3 commits into from
Jul 24, 2021

Conversation

jsturtevant
Copy link
Contributor

This feature was marked for depreciation in 1.20 and removed in 1.21: kubernetes/kubernetes#95505.

/sig windows
/kind cleanup

/cc @marosset

@k8s-ci-robot k8s-ci-robot requested a review from marosset July 15, 2021 16:10
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2021
@netlify
Copy link

netlify bot commented Jul 15, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: b078e49

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60fae1755ea16f00087ce46c

😎 Browse the preview: https://deploy-preview-28965--kubernetes-io-main-staging.netlify.app

sftim
sftim previously requested changes Jul 15, 2021
View reviewed changes
content/en/docs/reference/labels-annotations-taints.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2021
sftim
sftim reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubernetes/sig-windows-misc is this technically accurate?

content/en/docs/reference/labels-annotations-taints.md Outdated Show resolved Hide resolved
content/en/docs/reference/labels-annotations-taints.md Outdated Show resolved Hide resolved
@sftim sftim dismissed their stale review July 22, 2021 18:56

Review was outdated

@jsturtevant @sftim
Apply suggestions from code review
b078e49 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@jsturtevant
Copy link
Contributor Author

/assign @marosset

@marosset
Copy link
Contributor

/lgtm
/approve

Thanks for the updates!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1e53fecef14503ba98e33b89f469de0b589de5af

sftim
sftim reviewed Jul 24, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 777fe8e into kubernetes:main Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@marosset marosset Awaiting requested review from marosset

Assignees

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsturtevant @marosset @k8s-ci-robot @sftim