Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs about cloud-controller-manager #2900

Merged
merged 3 commits into from
Mar 21, 2017

Conversation

wlan0
Copy link
Member

@wlan0 wlan0 commented Mar 17, 2017

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2017
@thockin thockin assigned thockin and devin-donnelly and unassigned lavalamp Mar 17, 2017
@thockin thockin added this to the 1.6 milestone Mar 17, 2017
@thockin
Copy link
Member

thockin commented Mar 17, 2017

LGTM from content.

@devin-donnelly
Copy link
Contributor

@wlan0 Since this PR needs a bunch of general grammar, usage, and formatting fixes, would you mind providing maintainers access to edit it? I can fix them pretty quickly and it would save us some back and forth.

@wlan0
Copy link
Member Author

wlan0 commented Mar 21, 2017

@devin-donnelly done

@devin-donnelly
Copy link
Contributor

Added two commits for grammar, wording, and usage. Didn't change any technical content.

@devin-donnelly devin-donnelly merged commit f9c06f4 into kubernetes:release-1.6 Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants