Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Add content/hi/docs/home/supported-doc-versions.md #29372

Conversation

verma-kunal
Copy link
Contributor

Issue -> #29356

This PR is a part of ongoing hi localization effort

/language hi

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/hi Issues or PRs related to Hindi language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 13, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @verma-kunal!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 13, 2021
@netlify
Copy link

netlify bot commented Aug 13, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: b6edcef

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6117fcdab8425400075b6489

😎 Browse the preview: https://deploy-preview-29372--kubernetes-io-main-staging.netlify.app

Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to have some common words written the same way everywhere. We will soon make a Google sheet file with these words and their Hindi translations (just like the previous effort)

@verma-kunal
Copy link
Contributor Author

@anubha-v-ardhan , i think दस्तावेज़ीकरण was a better word to be used here!! don't you think?

Screenshot 2021-08-13 at 8 22 52 PM

Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anubha-v-ardhan
Copy link
Member

anubha-v-ardhan commented Aug 13, 2021

@verma-kunal Both प्रलेखन and दस्तावेज़ीकरण means the same, but प्रलेखन is a more formal alternative. The last localization effort was also using प्रलेखन as they had mention in their Google sheets file.

@verma-kunal
Copy link
Contributor Author

@verma-kunal Both प्रलेखन and दस्तावेज़ीकरण means the same, but प्रलेखन is a more formal alternative. The last localization effort was also using प्रलेखन as they had mention in their Google sheets file.

sure, understood!!! Thank you 🙂

@mittalyashu
Copy link
Member

@anubha-v-ardhan

We want to have some common words written the same way everywhere. We will soon make a Google sheet file with these words and their Hindi translations (just like the previous effort)

I've created one a long time ago, it should also be pinned in hindi slack channel for Kubernetes

https://docs.google.com/spreadsheets/d/1UmL4K0v4yaN34k4WzYDZBobLBp5OZQp4GCTi28AfwQM/edit#gid=0

@verma-kunal
Copy link
Contributor Author

@anubha-v-ardhan

We want to have some common words written the same way everywhere. We will soon make a Google sheet file with these words and their Hindi translations (just like the previous effort)

I've created one a long time ago, it should also be pinned in hindi slack channel for Kubernetes

https://docs.google.com/spreadsheets/d/1UmL4K0v4yaN34k4WzYDZBobLBp5OZQp4GCTi28AfwQM/edit#gid=0

Yeah, we can add more into this as well !! Thank you for sharing

@anubha-v-ardhan
Copy link
Member

Sorry @mittalyashu , we thought you are inactive and we didn't had edit access for that sheet. Glad to see you. We will use the existing file then : )

@mittalyashu
Copy link
Member

@anubha-v-ardhan I tried continue working on it but gradually other Hindi contributors also left and then somewhere I also lost interest 😞

Glad to see more contributors coming back.

@anubha-v-ardhan
Copy link
Member

@mittalyashu No worries, We are determined to finish the work this time. Please keep guiding us and reviewing our PRs and giving your valuable suggestions. Most of the folks in new team are newbies (including me)

@verma-kunal
Copy link
Contributor Author

@anubha-v-ardhan I tried continue working on it but gradually other Hindi contributors also left and then somewhere I also lost interest 😞

Glad to see more contributors coming back.

Glad to have you back with us @mittalyashu !! Would really look forward to your guidances & suggestions 😃✨

@verma-kunal
Copy link
Contributor Author

Done!! Thanks @mittalyashu for the review

@@ -0,0 +1,11 @@
---
title: उपलब्ध प्रलेखन संस्करण
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: उपलब्ध प्रलेखन संस्करण
title: प्रलेखन के उपलब्ध संस्करण

This makes sentence more easy to read and understand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verma-kunal
Can we commit these suggestions if you agree with the changes. We will be ready to merge this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to commit these!! its showing Outdated suggestion!!
should i do this manually?

@mittalyashu
Copy link
Member

/assign verma-kunal

@verma-kunal verma-kunal changed the title Add content/hi/docs/home/supported-doc-versions.md [hi] Add content/hi/docs/home/supported-doc-versions.md Aug 20, 2021
@verma-kunal verma-kunal changed the base branch from main to dev-1.22-hi.1 September 12, 2021 16:20
@verma-kunal verma-kunal marked this pull request as ready for review September 12, 2021 16:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2021
@anubha-v-ardhan
Copy link
Member

@verma-kunal After commiting the suggestions, Can we squash the commits into one and rebase before merging please

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@anubha-v-ardhan
Copy link
Member

/remove-approve

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@verma-kunal
Copy link
Contributor Author

@verma-kunal After commiting the suggestions, Can we squash the commits into one and rebase before merging please

sure!! would do that

Update content/hi/docs/home/supported-doc-versions.md

Co-authored-by: Yashu Mittal <mittalyashu77@gmail.com>
@verma-kunal verma-kunal force-pushed the Hindi-localization-docs/home2 branch from b37beff to 2689435 Compare September 13, 2021 09:11
@anubha-v-ardhan
Copy link
Member

/lgtm
/approve

Thank you @verma-kunal :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d32be2f36e1049c4b73b034cb73da881bab4fe6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 634983c into kubernetes:dev-1.22-hi.1 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants