-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hi] Add content/hi/docs/home/supported-doc-versions.md #29372
[hi] Add content/hi/docs/home/supported-doc-versions.md #29372
Conversation
Welcome @verma-kunal! |
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: b6edcef 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6117fcdab8425400075b6489 😎 Browse the preview: https://deploy-preview-29372--kubernetes-io-main-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to have some common words written the same way everywhere. We will soon make a Google sheet file with these words and their Hindi translations (just like the previous effort)
@anubha-v-ardhan , i think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@verma-kunal Both |
sure, understood!!! Thank you 🙂 |
I've created one a long time ago, it should also be pinned in hindi slack channel for Kubernetes https://docs.google.com/spreadsheets/d/1UmL4K0v4yaN34k4WzYDZBobLBp5OZQp4GCTi28AfwQM/edit#gid=0 |
Yeah, we can add more into this as well !! Thank you for sharing |
Sorry @mittalyashu , we thought you are inactive and we didn't had edit access for that sheet. Glad to see you. We will use the existing file then : ) |
@anubha-v-ardhan I tried continue working on it but gradually other Hindi contributors also left and then somewhere I also lost interest 😞 Glad to see more contributors coming back. |
@mittalyashu No worries, We are determined to finish the work this time. Please keep guiding us and reviewing our PRs and giving your valuable suggestions. Most of the folks in new team are newbies (including me) |
Glad to have you back with us @mittalyashu !! Would really look forward to your guidances & suggestions 😃✨ |
Done!! Thanks @mittalyashu for the review |
@@ -0,0 +1,11 @@ | |||
--- | |||
title: उपलब्ध प्रलेखन संस्करण |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: उपलब्ध प्रलेखन संस्करण | |
title: प्रलेखन के उपलब्ध संस्करण |
This makes sentence more easy to read and understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@verma-kunal
Can we commit these suggestions if you agree with the changes. We will be ready to merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to commit these!! its showing Outdated suggestion
!!
should i do this manually?
/assign verma-kunal |
@verma-kunal After commiting the suggestions, Can we squash the commits into one and rebase before merging please |
/remove-approve |
sure!! would do that |
Update content/hi/docs/home/supported-doc-versions.md Co-authored-by: Yashu Mittal <mittalyashu77@gmail.com>
b37beff
to
2689435
Compare
/lgtm Thank you @verma-kunal :) |
LGTM label has been added. Git tree hash: 0d32be2f36e1049c4b73b034cb73da881bab4fe6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anubha-v-ardhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue -> #29356
This PR is a part of ongoing
hi
localization effort/language hi