Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Add content/hi/docs/tutorial/kubernetes-basics/_index.html #29391

Merged
merged 10 commits into from
Oct 20, 2021
Merged

[hi] Add content/hi/docs/tutorial/kubernetes-basics/_index.html #29391

merged 10 commits into from
Oct 20, 2021

Conversation

rajatgupta24
Copy link
Contributor

Hey folks, this is a PR for hi localization of the file: content/hi/docs/tutorial/kubernetes-basics/_index.html
PR is linked under this issue #29353

/language hi

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/hi Issues or PRs related to Hindi language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @rajatgupta24!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2021
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Aug 14, 2021
Closed
52 tasks
verma-kunal
verma-kunal reviewed Aug 14, 2021
View reviewed changes
Copy link
Contributor

@verma-kunal verma-kunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@anubha-v-ardhan
Copy link
Member

anubha-v-ardhan commented Aug 14, 2021 •
edited
Loading

Please note that the directory name is tutorials and not tutorial. Change the name of directory to avoid conflicts in future : ) Thanks

@netlify
Copy link

netlify bot commented Aug 14, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 934dea5

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6165a7eb34c0cf00071571cf

😎 Browse the preview: https://deploy-preview-29391--kubernetes-io-main-staging.netlify.app

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2021
@rajatgupta24
Copy link
Contributor Author

Please note that the directory name is tutorials and not tutorial. Change the name of directory to avoid conflicts in future : ) Thanks

Sorry, I made the changes, should I made the PR ready, I mean to move from draft mode.

@anubha-v-ardhan
Copy link
Member

anubha-v-ardhan commented Aug 14, 2021 •
edited
Loading

@rajatgupta24 No, keep the PR in draft mode for now. We will open PRs for review once we get a separate branch.
Also, I can't see any files in Files changed section.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2021
@rajatgupta24
Copy link
Contributor Author

@rajatgupta24 No, keep the PR in draft mode for now. We will open PRs for review once we get a separate branch.
Also, I can't see any files in Files changed section.

@anubha-v-ardhan, check now

@rajatgupta24
Copy link
Contributor Author

/assign @mittalyashu

@anubha-v-ardhan
Copy link
Member

/retitle [hi] Add content/hi/docs/tutorial/kubernetes-basics/_index.html

@k8s-ci-robot k8s-ci-robot changed the title Add content/hi/docs/tutorial/kubernetes-basics/_index.html [hi] Add content/hi/docs/tutorial/kubernetes-basics/_index.html Aug 20, 2021
@anubha-v-ardhan
Copy link
Member

@rajatgupta24 You can change the base branch to dev-1.22-hi.1

anubha-v-ardhan
anubha-v-ardhan suggested changes Oct 1, 2021
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change the base to dev-1.22-hi.1

content/hi/docs/tutorials/kubernetes-basics/_index.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/_index.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/_index.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/_index.html Outdated Show resolved Hide resolved
content/hi/docs/tutorials/kubernetes-basics/_index.html Outdated Show resolved Hide resolved
@anubha-v-ardhan
Copy link
Member

/assign

@rajatgupta24 @anubha-v-ardhan
Update content/hi/docs/tutorials/kubernetes-basics/_index.html
934dea5 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@rajatgupta24 rajatgupta24 marked this pull request as ready for review October 12, 2021 15:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2021
@rajatgupta24 rajatgupta24 changed the base branch from main to dev-1.22-hi.1 October 12, 2021 15:21
rajatgupta24 and others added 4 commits October 12, 2021 20:52
@rajatgupta24 @anubha-v-ardhan
Update content/hi/docs/tutorials/kubernetes-basics/_index.html
fea0223 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@rajatgupta24 @anubha-v-ardhan
Update content/hi/docs/tutorials/kubernetes-basics/_index.html
e681782 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@rajatgupta24 @anubha-v-ardhan
Update content/hi/docs/tutorials/kubernetes-basics/_index.html
ba19737 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@rajatgupta24 @anubha-v-ardhan
Update content/hi/docs/tutorials/kubernetes-basics/_index.html
ce42d3f 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@anubha-v-ardhan
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 13, 2021
@anubha-v-ardhan
Copy link
Member

/lgtm
/approve

Thank you @rajatgupta24

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ad63d559c3566c9f268505fcb5ecfa86487be342

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit fe65057 into kubernetes:dev-1.22-hi.1 Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verma-kunal verma-kunal verma-kunal left review comments

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan requested changes

@sftim sftim sftim left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

@mittalyashu mittalyashu Awaiting requested review from mittalyashu

Assignees

@mittalyashu mittalyashu

@anubha-v-ardhan anubha-v-ardhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajatgupta24 @k8s-ci-robot @anubha-v-ardhan @sftim @verma-kunal @mittalyashu