-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hi] Add content/hi/docs/tutorials/hello-minikube.md #29396
[hi] Add content/hi/docs/tutorials/hello-minikube.md #29396
Conversation
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 444d14e 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/611ba452186dae0007443fd6 😎 Browse the preview: https://deploy-preview-29396--kubernetes-io-main-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some early feedback - hope it's helpful
/assign anubha-v-ardhan |
/lgtm |
LGTM label has been added. Git tree hash: bbe41ad296afdd17a1a4a2b5d3a17cd622e4b69c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling nits need to be addressed. Otherwise lgtm.
|
||
आमतौर पर, पॉड कुबेरनेट्स क्लस्टर के भीतर अपने आंतरिक IP पते से ही पहुँचा जा सकता है। | ||
`hello-node` कंटेनर को बहार से कुबेरनेटेस वर्चुअल नेटवर्क के | ||
बहार से सुलभ बनाने के लिए,पॉड को |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming you mean outside the network, in which case it would be बाहर not बहार
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this sentence might need rephrasing. How about?
आमतौर पर, पॉड कुबेरनेट्स क्लस्टर के भीतर अपने आंतरिक IP पते से ही पहुँचा जा सकता है।
hello-node
कंटेनर को कुबेरनेटेस वर्चुअल नेटवर्क के
बाहर से सुलभ बनाने के लिए,पॉड को
कुबेरनेट्स Service(सर्विस) के रूप में बेनकाब करना होगा।
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @divya-mohan0209, Can we have a final review and lgtm, approve if everything's good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling nits, otherwise lgtm.
## सर्विस बनाएं | ||
|
||
आमतौर पर, पॉड कुबेरनेट्स क्लस्टर के भीतर अपने आंतरिक IP पते से ही पहुँचा जा सकता है। | ||
`hello-node` कंटेनर को कुबेरनेटेस वर्चुअल नेटवर्क के |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling nit: कुबेरनेटेस
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the suggestions & make changes.
Most are typos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standardization for the word deploy transliterated to Hindi. This is non-standard across this file currently.
पॉड में केवल एक कंटेनर है। कुबेरनेट्स | ||
[*डिप्लॉयमेंट*](/hi/docs/concepts/workloads/controllers/deployment/) आपके पॉड के स्वास्थ्य की | ||
जाँच करता है और यदि पॉड बंद हो जाता है तो पॉड के कंटेनर को पुनः आरंभ करता है। | ||
पॉड्स के निर्माण और स्केलिंग को प्रबंधित करने के लिए डिप्लॉयमेंट अनुशंसित तरीका है। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
पॉड्स के निर्माण और स्केलिंग को प्रबंधित करने के लिए डिप्लॉयमेंट अनुशंसित तरीका है। | |
पॉड्स के निर्माण और स्केलिंग को प्रबंधित करने के लिए डिप्लॉयमेंट अनुशंसित तरीका है। |
My concern with the word डिप्लॉयमेंट is precisely this. We are using डेप्लॉय in some places and an alternate spelling in others. This needs to be standardized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on standardization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing, changing it to डेप्लॉयमेंट everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
Thanks @sftim @AvineshTripathi I've updated the page |
/label tide/merge-method-squash If you can squash commits here @anubha-v-ardhan, please do. |
6e23f20
to
c6d588a
Compare
Done @sftim :) |
a1044a4
to
3c0bfb9
Compare
## {{% heading "objectives" %}} | ||
|
||
* मिनीक्यूब में एक नमूना एप्लीकेशन डेप्लॉय करें। | ||
* ऐप को चलाएं। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ऐप चलाएं। should be enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ऐप को चलाएं" sounds in sync with "run the app", (putting some weight on the word app is a good idea I guess?)
"ऐप चलाएं" is like saying "run app".
The English version also uses "run the app".
I found this article which quickly explains को's grammar :)
https://hindilanguage.info/hindi-grammar/postpositions/ko/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @anubha-v-ardhan 's suggestion I think it is okay to keep ऐप को चलाएं
as it is, also I feel it sounds much better/clearer.
minikube dashboard | ||
``` | ||
|
||
3. केवल काटाकोडा वातावरण के लिए: टर्मिनल फलक के शीर्ष पर, प्लस(+) चिह्न पर क्लिक करें, और फिर **Select port to view on Host 1** क्लिक करें। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
करें, फिर delivers same meaning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My opinion would be to keep "फिर" in the sentence to make things more clear. English version also uses "then" which is same as using "फिर"
|
||
3. केवल काटाकोडा वातावरण के लिए: टर्मिनल फलक के शीर्ष पर, प्लस(+) चिह्न पर क्लिक करें, और फिर **Select port to view on Host 1** क्लिक करें। | ||
|
||
4. केवल काटाकोडा वातावरण के लिए: `30000` टाइप करें, और फिर **Display Port** क्लिक करें। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for line 58
`--type=LoadBalancer` फ्लैग इंगित करता है कि आप क्लस्टर के बाहर | ||
अपने सर्विस को प्रदर्शित करना चाहते हैं। | ||
|
||
इमेज के अंदर एप्लिकेशन कोड `k8s.gcr.io/echoserver` केवल TCP पोर्ट 8080 पर सुनता है। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have an alternative for पर सुनता है?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest something, we need to convey "listens on TCP port 8080"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use either केवल TCP पोर्ट 8080 को सुनता हैं।
or केवल TCP पोर्ट 8080 पे सुनता हैं।
for this. I also feel it will be okay even if we go with the original sentence. Thoughts?
Could you rebase this against current dev-1.22-hi.1 @anubha-v-ardhan? That would make it easier to preview the change. |
Create hello-minikube.md Update hello-minikube.md Update hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update hello-minikube.md Update hello-minikube.md Update hello-minikube.md Update hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Update hello-minikube.md Update content/hi/docs/tutorials/hello-minikube.md Co-Authored-By: Tim Bannister <tim@scalefactory.com> Co-Authored-By: divya-mohan0209 <divya.mohan0209@gmail.com> Co-Authored-By: Avinesh Tripathi <73980067+AvineshTripathi@users.noreply.github.com>
3c0bfb9
to
c922f43
Compare
@sftim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammatical changes + nits improving readability.
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 37c5b03245e740f5d1239b0cd9eb666db76b8c67
|
Self approving wrt #29396 (review) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anubha-v-ardhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is a part of ongoing
hi
localization attempt here #29353/language hi