Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Add content/hi/docs/tasks/tools/install-kubectl-macos.md #29461

Merged
merged 5 commits into from
Oct 2, 2021
Merged

[hi] Add content/hi/docs/tasks/tools/install-kubectl-macos.md #29461

merged 5 commits into from
Oct 2, 2021

Conversation

vedant-kakde
Copy link
Contributor

@vedant-kakde vedant-kakde commented Aug 18, 2021 •
edited
Loading

Localizes

  • content/hi/docs/tasks/tools/install-kubectl-macos.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 18, 2021
@vedant-kakde
Copy link
Contributor Author

This PR is in continuation of hi localization effort: #29353

/language hi

@vedant-kakde vedant-kakde mentioned this pull request Aug 18, 2021
Closed
52 tasks
@netlify
Copy link

netlify bot commented Aug 18, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 054001c

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/611d407c63d9d600074236ac

😎 Browse the preview: https://deploy-preview-29461--kubernetes-io-main-staging.netlify.app

@vedant-kakde vedant-kakde marked this pull request as draft August 18, 2021 15:23
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2021
vedant-kakde and others added 2 commits August 18, 2021 21:59
@vedant-kakde @mittalyashu
Apply suggestions from code review
1e408b0 
Co-authored-by: Yashu Mittal <mittalyashu77@gmail.com>
@vedant-kakde
Update install-kubectl-macos.md
054001c
@mittalyashu
Copy link
Member

/assign vedant-kakde

@anubha-v-ardhan
Copy link
Member

/retitle [hi] Add content/hi/docs/tasks/tools/install-kubectl-macos.md

@k8s-ci-robot k8s-ci-robot changed the title Add content/hi/docs/tasks/tools/install-kubectl-macos.md [hi] Add content/hi/docs/tasks/tools/install-kubectl-macos.md Aug 20, 2021
@vedant-kakde vedant-kakde changed the base branch from main to dev-1.22-hi.1 September 13, 2021 05:41
@vedant-kakde vedant-kakde marked this pull request as ready for review September 13, 2021 05:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2021
@vedant-kakde vedant-kakde mentioned this pull request Sep 24, 2021
Closed
7 tasks
anubha-v-ardhan
anubha-v-ardhan suggested changes Oct 2, 2021
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@anubha-v-ardhan
Copy link
Member

/assign

@vedant-kakde @anubha-v-ardhan
Apply suggestions from code review
9de3a85 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@vedant-kakde
Copy link
Contributor Author

Thanks for reviewing @anubha-v-ardhan 🙂

@anubha-v-ardhan
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 2, 2021
anubha-v-ardhan
anubha-v-ardhan suggested changes Oct 2, 2021
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final Review
Thanks

@vedant-kakde @anubha-v-ardhan
Update content/hi/docs/tasks/tools/install-kubectl-macos.md
a0000df 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@anubha-v-ardhan
Copy link
Member

/lgtm
/approve

Thank you @vedant-kakde :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 042172b64000593d46c22f71ca58e6f534aaa742

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6b92e5a into kubernetes:dev-1.22-hi.1 Oct 2, 2021
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Oct 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mittalyashu mittalyashu mittalyashu left review comments

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan requested changes

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@vedant-kakde vedant-kakde

@anubha-v-ardhan anubha-v-ardhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vedant-kakde @mittalyashu @anubha-v-ardhan @k8s-ci-robot @sftim