-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo a extension
and its related en
doc sync
#29486
Conversation
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 340125a 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61221fcc7f061b00079a5c44 😎 Browse the preview: https://deploy-preview-29486--kubernetes-io-main-staging.netlify.app |
/hold
|
Got it.
PTAL thanks. |
这是我在 main 分支进行对比中英版本的区别(注意,切换到 main 分支,你现在的分支已经 commit,时间是晚于 main 的最新分支的): $ git status
On branch main
Your branch is up to date with 'upstream/main'.
$ ./scripts/lsync.sh content/zh/docs/tasks/extend-kubernetes/configure-aggregation-layer.md
diff --git a/content/en/docs/tasks/extend-kubernetes/configure-aggregation-layer.md b/content/en/docs/tasks/extend-kubernetes/configure-aggregation-layer.md
index 739a69d45..3b65d6abc 100644
--- a/content/en/docs/tasks/extend-kubernetes/configure-aggregation-layer.md
+++ b/content/en/docs/tasks/extend-kubernetes/configure-aggregation-layer.md
@@ -17,7 +17,7 @@ Configuring the [aggregation layer](/docs/concepts/extend-kubernetes/api-extensi
{{< include "task-tutorial-prereqs.md" >}} {{< version-check >}}
{{< note >}}
-There are a few setup requirements for getting the aggregation layer working in your environment to support mutual TLS auth between the proxy and extension apiservers. Kubernetes and the kube-apiserver have multiple CAs, so make sure that the proxy is signed by the aggregation layer CA and not by something else, like the master CA.
+There are a few setup requirements for getting the aggregation layer working in your environment to support mutual TLS auth between the proxy and extension apiservers. Kubernetes and the kube-apiserver have multiple CAs, so make sure that the proxy is signed by the aggregation layer CA and not by something else, like the Kubernetes general CA.
{{< /note >}}
{{< caution >}}
|
Got it in |
We either don't fix it, or we resync the whole page. The goal is to make sure that once the page is updated, it is completely resynced with the English upstream version. This may sound a little bit inconvenient, but it really makes our lives a lot easier. |
4127e38
to
340125a
Compare
a extension
in a new PRa extension
and its related en
doc sync
Got it. Checked the diff in |
/lgtm |
LGTM label has been added. Git tree hash: 74ef8463571eedc912aac59e98b6c4ae87b35b4a
|
@mengjiao-liu Could you please help to approve this PR? PTAL thanks. |
/assign @tengqm |
/lgtm |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After review feedback(#29450), a new PR to fixed typo
a extension
toan extension
, to better the documents.