-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Minikube 1.20 image of Katacoda for Hello Minikube Tutorial #29616
Move to Minikube 1.20 image of Katacoda for Hello Minikube Tutorial #29616
Conversation
Signed-off-by: Ben Hall <ben@benhall.me.uk>
@sftim Did I somehow break the Netlify integration with my force push? |
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 280e67a 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61331914eec6070008facdcd 😎 Browse the preview: https://deploy-preview-29616--kubernetes-io-main-staging.netlify.app |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHall This LGTM and accomplishes what I think you set out to do.
Some clarification from what I'm seeing though
Starting Kubernetes...minikube version: v1.18.0
commit: ec61815d60f66a6e4f6353030a40b12362557caa-dirty
* minikube v1.18.0 on Ubuntu 18.04 (kvm/amd64)
* Using the none driver based on existing profile
X The requested memory allocation of 2200MiB does not leave room for system overhead (total system memory: 2460MiB). You may face stability issues.
* Suggestion: Start minikube with less memory allocated: 'minikube start --memory=2200mb'
* Starting control plane node minikube in cluster minikube
* Running on localhost (CPUs=2, Memory=2460MB, Disk=194868MB) ...
* OS release is Ubuntu 18.04.5 LTS
* Preparing Kubernetes v1.20.2 on Docker 19.03.13 ...
Technically, it looks like it's running Minikube 1.18 and deploys k8s 1.20.2. Which I think is still fine. Just may be good to clarify in case someone comes across this issue in the future.
@tylerauerbeck Good point. Yes the version tag is Kubernetes, not Minikube itself. |
/label team/katacoda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BenHall
/lgtm
/approve
LGTM label has been added. Git tree hash: ac2ac2d63b46bd2805b7524a30867d7c23eb2786
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim, tylerauerbeck The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ben Hall ben@benhall.me.uk
Replaces #29615 with now signed commit. Sorry.
Fixes #29204
Upgrades the tutorial to use Minikube 1.20 which is the latest version available on Katacoda.