Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Minikube 1.20 image of Katacoda for Hello Minikube Tutorial #29616

Merged

Conversation

BenHall
Copy link
Contributor

@BenHall BenHall commented Sep 4, 2021

Signed-off-by: Ben Hall ben@benhall.me.uk

Replaces #29615 with now signed commit. Sorry.

Fixes #29204

Upgrades the tutorial to use Minikube 1.20 which is the latest version available on Katacoda.

Signed-off-by: Ben Hall <ben@benhall.me.uk>
@BenHall
Copy link
Contributor Author

BenHall commented Sep 4, 2021

@sftim Did I somehow break the Netlify integration with my force push?

@netlify
Copy link

netlify bot commented Sep 4, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 280e67a

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61331914eec6070008facdcd

😎 Browse the preview: https://deploy-preview-29616--kubernetes-io-main-staging.netlify.app

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 4, 2021
Copy link
Contributor

@tylerauerbeck tylerauerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenHall This LGTM and accomplishes what I think you set out to do.

Some clarification from what I'm seeing though

Starting Kubernetes...minikube version: v1.18.0
commit: ec61815d60f66a6e4f6353030a40b12362557caa-dirty
* minikube v1.18.0 on Ubuntu 18.04 (kvm/amd64)
* Using the none driver based on existing profile

X The requested memory allocation of 2200MiB does not leave room for system overhead (total system memory: 2460MiB). You may face stability issues.
* Suggestion: Start minikube with less memory allocated: 'minikube start --memory=2200mb'

* Starting control plane node minikube in cluster minikube
* Running on localhost (CPUs=2, Memory=2460MB, Disk=194868MB) ...
* OS release is Ubuntu 18.04.5 LTS
* Preparing Kubernetes v1.20.2 on Docker 19.03.13 ...

Technically, it looks like it's running Minikube 1.18 and deploys k8s 1.20.2. Which I think is still fine. Just may be good to clarify in case someone comes across this issue in the future.

@BenHall
Copy link
Contributor Author

BenHall commented Sep 6, 2021

@tylerauerbeck Good point. Yes the version tag is Kubernetes, not Minikube itself.

@sftim
Copy link
Contributor

sftim commented Sep 7, 2021

/label team/katacoda

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenHall
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac2ac2d63b46bd2805b7524a30867d7c23eb2786

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, tylerauerbeck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. team/katacoda Issues with the Katacoda infrastructure for tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minikube playground (Katacoda) uses dated Kubernetes version
5 participants