-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ko] fixed Wrong Korean translations #30287
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I signed on CLA agreement |
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 640cfa1 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/617b195a5afed900088ac899 😎 Browse the preview: https://deploy-preview-30287--kubernetes-io-main-staging.netlify.app |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
@suhhee1011 Thank you for contributing can you check if you have signed the CLA correctly link |
Hi @AvineshTripathi , I just signed the CLA agreement :) Can you please recheck it? |
/check-cla |
I signed it |
/assign |
/check-cla |
c71bacd
to
ba84f81
Compare
ba84f81
to
640cfa1
Compare
@suhhee1011 We have a special~ development branch for Korean localization based on a milestone strategy :) Currently, it is dev.1.22-ko.2 (https://github.com/kubernetes/website/tree/dev-1.22-ko.2) So, could you rebase the base branch and target branch to dev-1.22-ko.2 branch ? Also, I'd like to introduce Slack channel for #kubernetes-docs-ko Thank you for the contribution. |
/retitle [ko] fixed Wrong Korean translations |
Thank you for signing and contributing 😄 |
@suhhee1011 Thank you for your interest and contribution for this project! 보통 assign은 reviewer/approver 를 하는 것 같아서, @suhhee1011 님 자신을 assign 하신 것은 해제하겠습니다. 😊 Previews:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suhhee1011 기여 감사합니다~~
커멘트를 작성해 보았습니다. 😊
PTAL!
@@ -122,7 +122,7 @@ web-1 1/1 Running 0 18s | |||
``` | |||
|
|||
참고로 `web-1` 파드는 `web-0` 파드가 _Running_ ([파드의 단계](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-단계-phase) 참고) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
참고로 `web-1` 파드는 `web-0` 파드가 _Running_ ([파드의 단계](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-단계-phase) 참고) | |
참고로 `web-1` 파드는 `web-0` 파드가 _Running_ ([파드의 단계](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-단계) 참고) |
@@ -122,7 +122,7 @@ web-1 1/1 Running 0 18s | |||
``` | |||
|
|||
참고로 `web-1` 파드는 `web-0` 파드가 _Running_ ([파드의 단계](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-단계-phase) 참고) | |||
및 _Ready_ ([파드의 조건](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-조건-condition)에서 `type` 참고) 상태가 되기 전에 시작하지 않음을 주의하자. | |||
및 _Ready_ ([파드의 컨디션](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-컨디션-condition)에서 `type` 참고) 상태가 되기 전에 시작하지 않음을 주의하자. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
및 _Ready_ ([파드의 컨디션](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-컨디션-condition)에서 `type` 참고) 상태가 되기 전에 시작하지 않음을 주의하자. | |
및 _Ready_ ([파드의 컨디션](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-컨디션)에서 `type` 참고) 상태가 되기 전에 시작하지 않음을 주의하자. |
/assign @jihoon-seo |
@suhhee1011 신규 마일스톤 공지 |
@suhhee1011 Thank you for your first contribution for Korean localization! Feel free to ask in Korean / English, or you can come to Korean Docs regular meeting if you would like to ask in details. Looking forward to your updates with @jihoon-seo 's guidance thank you both and all |
Closing due to author not responding to comments or feedback in 2 or more weeks, /close |
@jihoon-seo: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This Pull request is about fixed issue #29027.
I changed the Wrong translation in 3 files.
Please let me know if there is more place to edit the wrong translation.