-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for JobMutableNodeSchedulingDirectives #30390
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: 7f1a8f8 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/618b2f0e5005fa0009f1abdd |
/assign @alculquicondor @soltysh |
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
35c96eb
to
1b5fd70
Compare
done. |
/lgtm |
LGTM label has been added. Git tree hash: 214a512e2aa14b7c4e27b8240df91a6e12ab3881
|
It is enabled by default. | ||
{{< /note >}} | ||
|
||
In most cases a parallel job will want the pods to run within specific constraints, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "with constraints" or "within constraints"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
/label tide/merge-method-squash |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
In order to use this behavior, you must enable the `JobMutableNodeSchedulingDirectives` | ||
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/) | ||
on the [API server](/docs/reference/command-line-tools-reference/kube-apiserver/). | ||
It is enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this reads weird, maybe change the last sentence to say:
It is enabled by default. | |
In v1.23 it is enabled by default. |
LGTM label has been added. Git tree hash: 56cb3330dbaec46dbe91458cc6984aaf2c3dd4ba
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref kubernetes/enhancements#2926