Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for JobMutableNodeSchedulingDirectives #30390

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Nov 8, 2021

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Nov 8, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2021
@netlify
Copy link

netlify bot commented Nov 8, 2021

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 7f1a8f8

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/618b2f0e5005fa0009f1abdd

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 8, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Nov 8, 2021

/assign @alculquicondor @soltysh

@ahg-g ahg-g force-pushed the ahg-mutable branch 2 times, most recently from 35c96eb to 1b5fd70 Compare November 8, 2021 22:33
@ahg-g
Copy link
Member Author

ahg-g commented Nov 9, 2021

done.

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 214a512e2aa14b7c4e27b8240df91a6e12ab3881

It is enabled by default.
{{< /note >}}

In most cases a parallel job will want the pods to run within specific constraints,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "with constraints" or "within constraints"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@tengqm
Copy link
Contributor

tengqm commented Nov 10, 2021

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@tengqm
Copy link
Contributor

tengqm commented Nov 10, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

In order to use this behavior, you must enable the `JobMutableNodeSchedulingDirectives`
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
on the [API server](/docs/reference/command-line-tools-reference/kube-apiserver/).
It is enabled by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this reads weird, maybe change the last sentence to say:

Suggested change
It is enabled by default.
In v1.23 it is enabled by default.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 56cb3330dbaec46dbe91458cc6984aaf2c3dd4ba

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 14a003c into kubernetes:dev-1.23 Nov 10, 2021
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
trierra pushed a commit to trierra/website that referenced this pull request Nov 16, 2021
trierra pushed a commit to trierra/website that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants