Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Minor fixes to Windows projected volumes #30559

Merged
merged 1 commit into from
Nov 20, 2021
Merged

storage: Minor fixes to Windows projected volumes #30559

merged 1 commit into from
Nov 20, 2021

Conversation

aravindhp
Copy link
Contributor

@aravindhp aravindhp commented Nov 18, 2021 •
edited
Loading

Follow up to #30366:

  • Add missing period
  • Link to projected volume permission KEP instead of PR
  • Add missing PowerShell command

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 18, 2021 •
edited
Loading

CLA Not Signed

@aravindhp
Copy link
Contributor Author

/cc @sftim

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot requested a review from sftim November 18, 2021 23:46
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 18, 2021
@aravindhp
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Nov 18, 2021
@netlify
Copy link

netlify bot commented Nov 18, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 11f5db4

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61981016e460eb000717e9b7

😎 Browse the preview: https://deploy-preview-30559--kubernetes-io-main-staging.netlify.app

@aravindhp
storage: Minor fixes to Windows projected volumes
11f5db4 
- Add missing period
- Link to projected volume permission KEP instead of PR
- Add missing PowerShell command
@aravindhp aravindhp force-pushed the windows-projected-volume-follow-up branch from e0cc238 to 11f5db4 Compare November 19, 2021 20:59
mehabhalodiya
mehabhalodiya reviewed Nov 20, 2021
View reviewed changes
Copy link
Contributor

@mehabhalodiya mehabhalodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Thank you :)
/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 83994d3d0583c8bf19efe02c70eb8b217eccb94b

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2021
sftim
sftim reviewed Nov 20, 2021
View reviewed changes
content/en/docs/concepts/storage/projected-volumes.md
@@ -100,6 +100,8 @@ into their own volume mount outside of `C:\`.
By default, the projected files will have the following ownership as shown for
an example projected volume file:
```powershell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, this isn't PowerShell code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought adding the PowerShell command would make it appropriate 🤦🏽‍♂️ . Sorry about that. I will fix it if I am modifying this area again.

sftim
sftim reviewed Nov 20, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 000a9de into kubernetes:main Nov 20, 2021
@aravindhp aravindhp mentioned this pull request Dec 2, 2021
Merged
@aravindhp aravindhp deleted the windows-projected-volume-follow-up branch February 25, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mehabhalodiya mehabhalodiya mehabhalodiya left review comments

@marosset marosset Awaiting requested review from marosset

@thockin thockin Awaiting requested review from thockin

Assignees

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aravindhp @k8s-ci-robot @sftim @mehabhalodiya