Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JobReadyPods feature gate #30593

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Add JobReadyPods feature gate #30593

merged 1 commit into from
Nov 30, 2021

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Nov 22, 2021 •
edited
Loading

Add state and description for JobReadyPods feature gate.

The rest of the documentation is on the API reference.

Ref kubernetes/enhancements#2879

/sig apps

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Nov 22, 2021
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Nov 22, 2021
@netlify
Copy link

netlify bot commented Nov 22, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: d42a12c

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/619ea31c5d64de0008fa7f1b

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 22, 2021
@alculquicondor alculquicondor mentioned this pull request Nov 22, 2021
Closed
14 tasks
@chrisnegus
Copy link
Contributor

/assign

@chrisnegus
Copy link
Contributor

@alculquicondor, I don't see a hold here so is this PR ready to review or are more docs needed?

@alculquicondor
Copy link
Member Author

This is ready for review.

sftim
sftim reviewed Nov 22, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits

(As we only expect alpha-quality docs at this point, the PR is fine to merge as-is, providing there's no objection from SIG Apps).

@alculquicondor
Copy link
Member Author

Applied the suggestions. Thanks!

/assign @soltysh

tengqm
tengqm reviewed Nov 23, 2021
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -131,6 +131,7 @@ different Kubernetes components.
| `JobMutableNodeSchedulingDirectives` | `true` | Beta | 1.23 | |
| `JobTrackingWithFinalizers` | `false` | Alpha | 1.22 | 1.22 |
| `JobTrackingWithFinalizers` | `true` | Beta | 1.23 | |
| `JobReadyPods` | `false` | Alpha | 1.23 | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this before line 132

@alculquicondor
Copy link
Member Author

Fixed order

@shannonxtreme
Copy link
Contributor

@alculquicondor did the order fixing that Qiming suggested work? I don't see a change (not sure if on my end)

@alculquicondor
Copy link
Member Author

Sorry, I forgot to push :|

@shannonxtreme
Copy link
Contributor

Thank you :) This looks great, thanks for the PR!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 63f07d8700ec1d62936ad1804fcbda45a54da664

@chrisnegus
Copy link
Contributor

/lgtm

@chrisnegus
Copy link
Contributor

@alculquicondor Is this ready to merge from your perspective?

@alculquicondor
Copy link
Member Author

yes

@chrisnegus
Copy link
Contributor

@alculquicondor Thanks!

soltysh
soltysh approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from sig-apps pov

@jlbutler
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlbutler, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit a8f9148 into kubernetes:dev-1.23 Nov 30, 2021
@chrisnegus
Copy link
Contributor

/lgtm from sig-apps pov

Thanks @soltysh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@sftim sftim sftim left review comments

@soltysh soltysh soltysh approved these changes

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@soltysh soltysh

@chrisnegus chrisnegus

@shannonxtreme shannonxtreme

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.
8 participants
@alculquicondor @chrisnegus @shannonxtreme @k8s-ci-robot @jlbutler @soltysh @tengqm @sftim