Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting the docs for label kubernetes.io/metadata.name #30631

Merged
merged 3 commits into from
Nov 26, 2021
Merged

Correcting the docs for label kubernetes.io/metadata.name #30631

merged 3 commits into from
Nov 26, 2021

Conversation

Babapool
Copy link
Member

Fixes #30614

The section is reworded in a manner that it now indicates that the Control Plane sets the label on the namespaces.

Files Changed: https://kubernetes.io/docs/reference/labels-annotations-taints/#kubernetes-io-metadata-name

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 25, 2021
@netlify
Copy link

netlify bot commented Nov 25, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 2ae0496

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/619fcf6d831e1f00086a7333

😎 Browse the preview: https://deploy-preview-30631--kubernetes-io-main-staging.netlify.app

sftim
sftim previously requested changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's how I'd write it @Babapool

content/en/docs/reference/labels-annotations-taints.md Outdated Show resolved Hide resolved
content/en/docs/reference/labels-annotations-taints.md Outdated Show resolved Hide resolved
@Babapool
Copy link
Member Author

Thanks @sftim for the feedback I will work on it

@Babapool
Copy link
Member Author

@sftim I have included the suggested changes. PTAL . Thanks

@Babapool Babapool requested a review from sftim November 25, 2021 09:25
@sftim
Copy link
Contributor

sftim commented Nov 25, 2021

@kubernetes/sig-api-machinery-pr-reviews happy with this?

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 25, 2021
@Babapool
Copy link
Member Author

Babapool commented Nov 25, 2021 •
edited
Loading

I will do the needful changes and commit the changes.

@Babapool
Copy link
Member Author

@sftim @liggitt I have made the necessary as suggested. PTAL. Thanks.

sftim
sftim reviewed Nov 26, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59b3a8eabb16db83e35a96b9ddf4519d9fbdf443

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 129b15b into kubernetes:main Nov 26, 2021
@Babapool Babapool mentioned this pull request Apr 20, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect docs for label kubernetes.io/metadata.name
4 participants
@Babapool @sftim @k8s-ci-robot @liggitt