Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Add content/hi/docs/concepts/overview/what-is-kubernetes.md #30847

Merged
merged 6 commits into from
Dec 16, 2021
Merged

[hi] Add content/hi/docs/concepts/overview/what-is-kubernetes.md #30847

merged 6 commits into from
Dec 16, 2021

Conversation

ashish-jaiswar
Copy link
Contributor

Added one file

Localized what-is-kubernetes.md to Hindi.
Follow -up to #30732

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2021
@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 10, 2021
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Dec 11, 2021
Closed
52 tasks
@ashish-jaiswar
Copy link
Contributor Author

@anubha-v-ardhan , @divya-mohan0209 please merge this PR? I have updated this file.

@divya-mohan0209
Copy link
Contributor

@ashish-jaiswar

Please review the comments I have entered previously. They haven't been addressed.

@ashish-jaiswar @anubha-v-ardhan
Update content/hi/docs/concepts/overview/what-is-kubernetes.md
f053d5d 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@ashish-jaiswar
Copy link
Contributor Author

hey @divya-mohan0209 , you haven't reviewed this PR yet. I think you have commented in different PR. Because I don't see your review comment.

@divya-mohan0209
Copy link
Contributor

divya-mohan0209 commented Dec 13, 2021 •
edited
Loading

Hello @ashish-jaiswar , the reviews will be marked as outdated since you have pushed a commit without addressing them

divya-mohan0209
divya-mohan0209 requested changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the necessary changes.

content/hi/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/hi/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/hi/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/hi/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
@divya-mohan0209
Copy link
Contributor

Re-reviewed it again.

@ashish-jaiswar
Copy link
Contributor Author

hi @divya-mohan0209 , @anubha-v-ardhan I have updated this file, if it looks good please merge this PR.

anubha-v-ardhan
anubha-v-ardhan suggested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final Review.

content/hi/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
content/hi/docs/concepts/overview/what-is-kubernetes.md Outdated Show resolved Hide resolved
ashish-jaiswar and others added 2 commits December 16, 2021 17:02
@ashish-jaiswar @anubha-v-ardhan
Update content/hi/docs/concepts/overview/what-is-kubernetes.md
a86fb15 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@ashish-jaiswar @anubha-v-ardhan
Update content/hi/docs/concepts/overview/what-is-kubernetes.md
4405a20 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@ashish-jaiswar
Copy link
Contributor Author

hey, @anubha-v-ardhan please merge this PR.

@anubha-v-ardhan
Copy link
Member

/label tide/merge-method-squash
/assign

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 16, 2021
@anubha-v-ardhan
Copy link
Member

/lgtm
/approve
Thank you @ashish-jaiswar, @kranurag7

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1eabf0f363bc79fa55ca2f54409fbde5ac216289

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Dec 16, 2021
Closed
@k8s-ci-robot k8s-ci-robot merged commit f9760fd into kubernetes:dev-1.22-hi.1 Dec 16, 2021
@Garima-Negi Garima-Negi mentioned this pull request Dec 21, 2021
Closed
7 tasks
@dipesh-rawat dipesh-rawat mentioned this pull request Sep 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garima-Negi Garima-Negi Garima-Negi requested changes

@sftim sftim sftim left review comments

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan requested changes

@divya-mohan0209 divya-mohan0209 divya-mohan0209 requested changes

@mittalyashu mittalyashu Awaiting requested review from mittalyashu

Assignees

@anubha-v-ardhan anubha-v-ardhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashish-jaiswar @divya-mohan0209 @anubha-v-ardhan @k8s-ci-robot @sftim @Garima-Negi