Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Update data/i18n/hi/hi.toml #31072

Merged
merged 1 commit into from
Jan 11, 2022
Merged

[hi] Update data/i18n/hi/hi.toml #31072

merged 1 commit into from
Jan 11, 2022

Conversation

Babapool
Copy link
Member

Fixes #31013

This PR updates the hi.toml by adding the 19 missing strings to make it at par with the en.toml.

Page updated:
https://github.com/kubernetes/website/blob/dev-1.22-hi.1/data/i18n/hi/hi.toml

(This is my first PR for the Hindi localization, please share any feedback so that I can improve for next time.)

Signed by Vitthal Sai : vitthalsai2001@gmail.com
/language hi

@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 22, 2021
@AvineshTripathi
Copy link
Contributor

Hey thanks for the contribution I have done the review and LGTM from myside

also looking in the file I see the hi.toml is differently organised in comparison to en.toml is this done intentionally was curious to know

sftim
sftim reviewed Dec 22, 2021
View reviewed changes
data/i18n/hi/hi.toml Outdated
other = "संक्षेप में"

[thirdparty_message]
other = """यह खंड तीसरे पक्ष की परियोजनाओं से जुड़ा है जो कुबेरनेट्स द्वारा आवश्यक कार्यक्षमता प्रदान करते हैं। कुबेरनेट्स परियोजना के लेखक इन परियोजनाओं के लिए जिम्मेदार नहीं हैं। यह पृष्ठ <a href="https://github.com/cncf/foundation/blob/master/website-guidelines.md" target="_blank">CNCF website guidelines</a> का अनुसरण करते हुए परियोजनाओं को वर्णानुक्रम में सूचीबद्ध करता है। इस सूची में कोई नयी परियोजना जोड़ने से पहले यह <a href="/docs/contribute/style/content-guide/#third-party-content">content guide</a> पृष्ट पढ़के ही परिवर्तन करें।"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd localize “content guide“.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sftim , I will do the needful

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

तीसरे पक्ष की परियोजनाओं is a literal transliteration. We're looking at third party in the context of these projects/products not being developed/maintained by the K8s community. The below suggestion fits better, IMO. WDYT?

Suggested change
other = """यह खंड तीसरे पक्ष की परियोजनाओं से जुड़ा है जो कुबेरनेट्स द्वारा आवश्यक कार्यक्षमता प्रदान करते हैं। कुबेरनेट्स परियोजना के लेखक इन परियोजनाओं के लिए जिम्मेदार नहीं हैं। यह पृष्ठ <a href="https://github.com/cncf/foundation/blob/master/website-guidelines.md" target="_blank">CNCF website guidelines</a> का अनुसरण करते हुए परियोजनाओं को वर्णानुक्रम में सूचीबद्ध करता है। इस सूची में कोई नयी परियोजना जोड़ने से पहले यह <a href="/docs/contribute/style/content-guide/#third-party-content">content guide</a> पृष्ट पढ़के ही परिवर्तन करें।"""
other = """यह खंड अन्य पक्ष परियोजनाओं से जुड़ा है जो कुबेरनेट्स द्वारा आवश्यक कार्यक्षमता प्रदान करते हैं। कुबेरनेट्स परियोजना के लेखक इन परियोजनाओं के लिए जिम्मेदार नहीं हैं। यह पृष्ठ <a href="https://github.com/cncf/foundation/blob/master/website-guidelines.md" target="_blank">CNCF website guidelines</a> का अनुसरण करते हुए परियोजनाओं को वर्णानुक्रम में सूचीबद्ध करता है। इस सूची में कोई नयी परियोजना जोड़ने से पहले यह <a href="/docs/contribute/style/content-guide/#third-party-content">content guide</a> पृष्ट पढ़के ही परिवर्तन करें।"""

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think using अन्य will be much better and it gives a clear idea of the context. I will the do the needful and push a new commit based on the feedback. Thank you.

sftim
sftim reviewed Dec 22, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Please try to have this file in alphabetical order (fixing that order could be a second commit) by the translation key.

The first entry should be [caution].

@Babapool
Copy link
Member Author

@AvineshTripathi I have no idea on how the hi.toml was arranged as compared to en.toml. It is better to ask the maintainers and reviewers on this issue. Thank for the LGTM.

@Babapool
Copy link
Member Author

@sftim I have seen how ja.toml , ko.toml and zh.toml are arranged. I am thinking to arrange hi.toml alphabetically wise mirroring en.toml (in English alphabetical order). If more people agree on arranging order I am happy to push another commit to rearrange the file. @anubha-v-ardhan @divya-mohan0209

@anubha-v-ardhan
Copy link
Member

@Babapool agreed, we should arrange it in alphabetical order.

@Babapool
Copy link
Member Author

Sure thing @anubha-v-ardhan , I will do the needful(arranging in English alphabetical order). Also can you suggested should Content Guide be translated or transliterated? Thanks

@divya-mohan0209
Copy link
Contributor

Sure thing @anubha-v-ardhan , I will do the needful(arranging in English alphabetical order). Also can you suggested should Content Guide be translated or transliterated? Thanks

I'd rather that it be translated if possible.

divya-mohan0209
divya-mohan0209 requested changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical nits.

data/i18n/hi/hi.toml Outdated Show resolved Hide resolved
data/i18n/hi/hi.toml Outdated
other = "संक्षेप में"

[thirdparty_message]
other = """यह खंड तीसरे पक्ष की परियोजनाओं से जुड़ा है जो कुबेरनेट्स द्वारा आवश्यक कार्यक्षमता प्रदान करते हैं। कुबेरनेट्स परियोजना के लेखक इन परियोजनाओं के लिए जिम्मेदार नहीं हैं। यह पृष्ठ <a href="https://github.com/cncf/foundation/blob/master/website-guidelines.md" target="_blank">CNCF website guidelines</a> का अनुसरण करते हुए परियोजनाओं को वर्णानुक्रम में सूचीबद्ध करता है। इस सूची में कोई नयी परियोजना जोड़ने से पहले यह <a href="/docs/contribute/style/content-guide/#third-party-content">content guide</a> पृष्ट पढ़के ही परिवर्तन करें।"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

तीसरे पक्ष की परियोजनाओं is a literal transliteration. We're looking at third party in the context of these projects/products not being developed/maintained by the K8s community. The below suggestion fits better, IMO. WDYT?

Suggested change
other = """यह खंड तीसरे पक्ष की परियोजनाओं से जुड़ा है जो कुबेरनेट्स द्वारा आवश्यक कार्यक्षमता प्रदान करते हैं। कुबेरनेट्स परियोजना के लेखक इन परियोजनाओं के लिए जिम्मेदार नहीं हैं। यह पृष्ठ <a href="https://github.com/cncf/foundation/blob/master/website-guidelines.md" target="_blank">CNCF website guidelines</a> का अनुसरण करते हुए परियोजनाओं को वर्णानुक्रम में सूचीबद्ध करता है। इस सूची में कोई नयी परियोजना जोड़ने से पहले यह <a href="/docs/contribute/style/content-guide/#third-party-content">content guide</a> पृष्ट पढ़के ही परिवर्तन करें।"""
other = """यह खंड अन्य पक्ष परियोजनाओं से जुड़ा है जो कुबेरनेट्स द्वारा आवश्यक कार्यक्षमता प्रदान करते हैं। कुबेरनेट्स परियोजना के लेखक इन परियोजनाओं के लिए जिम्मेदार नहीं हैं। यह पृष्ठ <a href="https://github.com/cncf/foundation/blob/master/website-guidelines.md" target="_blank">CNCF website guidelines</a> का अनुसरण करते हुए परियोजनाओं को वर्णानुक्रम में सूचीबद्ध करता है। इस सूची में कोई नयी परियोजना जोड़ने से पहले यह <a href="/docs/contribute/style/content-guide/#third-party-content">content guide</a> पृष्ट पढ़के ही परिवर्तन करें।"""

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 26, 2021
@Babapool
Copy link
Member Author

Hi all PTAL on the new changes. @divya-mohan0209 I am still confused on what to use for Content Guide please suggest on it. Thanks.

anubha-v-ardhan
anubha-v-ardhan suggested changes Dec 27, 2021
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Babapool
Some strings are still missing. It would be nice if you compare this with en.toml and add the missing ones

@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Dec 28, 2021
Closed
52 tasks
@Babapool
Copy link
Member Author

@anubha-v-ardhan Sure I will do the needful. Thanks

@Babapool
Copy link
Member Author

Hi @anubha-v-ardhan PTAL at the new changes I have pushed. Thanks (and Happy New Years Eve and Happy New Year in advance to all).

anubha-v-ardhan
anubha-v-ardhan suggested changes Jan 2, 2022
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use विषय मार्गदर्शक for content guide. It sounds much simpler and easier to understand.

data/i18n/hi/hi.toml Outdated Show resolved Hide resolved
data/i18n/hi/hi.toml Outdated Show resolved Hide resolved
@Babapool
Copy link
Member Author

Babapool commented Jan 3, 2022

I have added the fix for Content Guide as suggested. PTAL. Thanks. @anubha-v-ardhan @divya-mohan0209

divya-mohan0209
divya-mohan0209 reviewed Jan 3, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we should transliterate issue or if we can leave it as is. Thoughts, @sftim or @anubha-v-ardhan ?

@anubha-v-ardhan
Copy link
Member

I don't know if we should transliterate issue or if we can leave it as is. Thoughts, @sftim or @anubha-v-ardhan ?

I think we can leave it as it is

@Babapool
Copy link
Member Author

Babapool commented Jan 5, 2022

Hi all, do I need to do something else from my side regarding the PR.? Thanks.

@divya-mohan0209
Copy link
Contributor

@Babapool : I think you need to retain the word issue instead of transliterating it.

@Babapool
Copy link
Member Author

Babapool commented Jan 5, 2022

@divya-mohan0209: Just to confirm by meaning to retain the word Issue you mean to change/replace इशू by issue ?

@Babapool
Copy link
Member Author

Babapool commented Jan 7, 2022

Hi all, PTAL. Thanks. @anubha-v-ardhan @divya-mohan0209

anubha-v-ardhan
anubha-v-ardhan suggested changes Jan 9, 2022
View reviewed changes
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me
@divya-mohan0209 Is this PR an LGTM from you too?

@anubha-v-ardhan
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 11, 2022
@anubha-v-ardhan
Copy link
Member

@Babapool Can you squash the commits, I think we can merge this

@Babapool
Copy link
Member Author

Babapool commented Jan 11, 2022 •
edited
Loading

@anubha-v-ardhan I will squash the commits

@Babapool
Copy link
Member Author

Hi @anubha-v-ardhan I have squashed the commits into one. PTAL. Thanks.
/assign @anubha-v-ardhan

@sftim
Copy link
Contributor

sftim commented Jan 11, 2022

/remove-label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 11, 2022
@anubha-v-ardhan
Copy link
Member

/assign
/lgtm
/approve

Thank you @Babapool :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cfc7a30657815298621e03b79b161e18c9003d43

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 72e773b into kubernetes:dev-1.22-hi.1 Jan 11, 2022
@anubha-v-ardhan anubha-v-ardhan mentioned this pull request Jan 11, 2022
Closed
@Babapool Babapool mentioned this pull request Apr 20, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan requested changes

@mittalyashu mittalyashu Awaiting requested review from mittalyashu

@sftim sftim Awaiting requested review from sftim

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@anubha-v-ardhan anubha-v-ardhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Babapool @AvineshTripathi @anubha-v-ardhan @divya-mohan0209 @sftim @k8s-ci-robot