-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: use default strategic merge type in example #31112
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 29213de 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62068fd35a31ec00084a29cd 😎 Browse the preview: https://deploy-preview-31112--kubernetes-io-main-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like this is fixing a bug. We definitely want bug fixes.
If you were typing this out, you wouldn't need to specify strategic
type as that's the default. In docs, it's often helpful to be explicit - and that's why I've suggested retaining --type
.
content/en/docs/tasks/manage-kubernetes-objects/update-api-object-kubectl-patch.md
Outdated
Show resolved
Hide resolved
@huikang, can you outline the steps you've taken to verify that the updated page is accurate? That'll help us to review. |
Hi @huikang, a friendly ping are you still working on this PR? Thanks! |
Hi @huikang , please take a look at the recommendation in the earlier comment There's a possible merge conflict, please rebase @huikang , a PR Wrangler may close this PR if this PR is no longer worked on |
To make it consistent with the subsection title (Use strategic merge patch...)
…ect-kubectl-patch.md Co-authored-by: Tim Bannister <tim@scalefactory.com>
To make it consistent with the subsection title (Use strategic merge patch...)