Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Add content/hi/docs/contribute/_index.md #31162

Merged
merged 54 commits into from
Jan 11, 2022
Merged

[hi] Add content/hi/docs/contribute/_index.md #31162

merged 54 commits into from
Jan 11, 2022

Conversation

Nawaz027
Copy link
Contributor

@Nawaz027 Nawaz027 commented Jan 1, 2022

localized the file from website/content/en/docs/contribute/_index.md
@anubha-v-ardhan please have a look

localized the file from website/content/en/docs/contribute/_index.md
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 1, 2022
@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 1, 2022
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nawaz027 at the moment, this doesn't look good enough to merge. My guess is that this is an unamended machine translation (these are rarely good enough to accept).

Whatever the explanation, this would need careful revision before we could accept it.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical nits & reviews provided.

@anubha-v-ardhan
Copy link
Member

fixes #31012

@Nawaz027
Copy link
Contributor Author

Nawaz027 commented Jan 3, 2022

noted, thanks @sftim @divya-mohan0209

Nawaz027 and others added 18 commits January 6, 2022 17:33
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
Nawaz027 and others added 16 commits January 11, 2022 20:16
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Garima Negi <garima.negy@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final Review

Nawaz027 and others added 3 commits January 11, 2022 22:07
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
@anubha-v-ardhan
Copy link
Member

/assign
/label tide/merge-method-squash

@anubha-v-ardhan
Copy link
Member

/lgtm
/approve

Thank you @Nawaz027 :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ffb6cc9b5db0e9e977a432f9f9459d7820815fd5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8fa492b into kubernetes:dev-1.22-hi.1 Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants