Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi] Add docs/reference/_index.md to Hindi localization #31185

Merged

Conversation

Garima-Negi
Copy link
Contributor

@Garima-Negi Garima-Negi commented Jan 3, 2022

Issue : #31011

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Garima-Negi!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 3, 2022
@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 3, 2022
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Garima-Negi, the file should be _index.md and not index.md. I'm afraid we have a typo here.

@anubha-v-ardhan
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2022
content/hi/docs/reference/_index.md Outdated Show resolved Hide resolved
* [कुबेरनेट्स के लिए एक-पृष्ठ API संदर्भ {{< param "version" >}}](/docs/reference/generated/kubernetes-api/{{< param "version" >}}/)
* [कुबेरनेट्स API का उपयोग करना](/docs/reference/using-api/) - कुबेरनेट्स के लिए एपीआई का अवलोकन।
* [API अभिगम नियंत्रण](/docs/reference/access-authn-authz/) - कुबेरनेट्स API एक्सेस को कैसे नियंत्रित करता है, इस पर विवरण।
* [जाने-माने लेबल, एनोटेशन और दाग](/docs/reference/labels-annotations-taints/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this but should we use another word inplace of दाग as it has multiple meaning and I am not sure if that matches actual meaning of taints. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use टिप्पणी instead एनोटेशन. Also I feel it it is better to transliterate taints (but I can suggest अभिमिश्रण for the same). Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have replaced एनोटेशन with टिप्पणी.

Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't include the approvers: in localized version in general

content/hi/docs/reference/_index.md Outdated Show resolved Hide resolved
Copy link
Member

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe निर्देश better portrays the meaning of reference here instead of संदर्भ
Thoughts?

@Garima-Negi
Copy link
Contributor Author

I believe निर्देश better portrays the meaning of reference here instead of संदर्भ Thoughts?

I think निर्देश aligns more with instructions whereas this page is simply a collection of links to more documentation. Hence, संदर्भ might be more apt. Let me know if I should still change it.

@anubha-v-ardhan
Copy link
Member

anubha-v-ardhan commented Jan 6, 2022

My bad, संदर्भ should be fine. Sorry for trouble.
Please have a look at #31185 (comment)


* [kubectl](/docs/reference/kubectl/overview/) - कमांड चलाने और कुबेरनेट्स क्लस्टर के प्रबंधन के लिए मुख्य CLI उपकरण।
* [JSONPath](/docs/reference/kubectl/jsonpath/) - kubectl के साथ प्रयोग करने के लिए
वाक्य - विन्यास मार्गदर्शक [JSONPath expressions](https://goessner.net/articles/JsonPath/).
Copy link
Member

@Babapool Babapool Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use वाक्य-रचना for syntax as it is more simpler to understand and use. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax is a term used in context of programming language (JSONPath here). I think we should go with transliteration for syntax to avoid confusions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added syntax as सिन्‌टैक्‍स् with वाक्य-रचना as explanation in parenthesis

content/hi/docs/reference/_index.md Outdated Show resolved Hide resolved
content/hi/docs/reference/_index.md Outdated Show resolved Hide resolved
@verma-kunal
Copy link
Contributor

Hey @Garima-Negi , great work on the PR!
if don't we have any further changes to be added here, its good to go for squashing the commits & then merging

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2022
@Garima-Negi
Copy link
Contributor Author

/assign @sftim

@sftim
Copy link
Contributor

sftim commented Jan 11, 2022

I don't speak Hindi and don't have current plans to learn it.
/unassign

I can't review this PR I'm afraid.

@anubha-v-ardhan
Copy link
Member

@Garima-Negi This PR is ready to be approved. We need to squash the commits though. Can you do that?
We can squash it using the label too if any issues.

@anubha-v-ardhan
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 11, 2022
@anubha-v-ardhan
Copy link
Member

anubha-v-ardhan commented Jan 11, 2022

/remove-label do-not-merge/hold

@k8s-ci-robot
Copy link
Contributor

@anubha-v-ardhan: The label(s) /remove-label do-not-merge/hold cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

/remove-label do-not-merge/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anubha-v-ardhan
Copy link
Member

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2022
@anubha-v-ardhan
Copy link
Member

/assign
/lgtm
/approve

Thank you @Garima-Negi

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4e81dd655726bd74e8626e7a6fbf7089c70a7024

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubha-v-ardhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 269b037 into kubernetes:dev-1.22-hi.1 Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants